Biome dust: Revert fix that added dust to mod structures (#7464)

paramat · web-flow · commit 86389329eba1 · 2018-06-19T22:09:42.000+01:00
Revert commit 99143f4 and commit f4ca830. These commits caused biome dust to be applied even when there was no core mapgen terrain in a mapchunk column. So the dust, which overgenerates, then appeared on structures added by mods in 'on_generated', such as floatlands, asteroids or above-surface realms.
diff --git a/src/mapgen/mapgen.cpp b/src/mapgen/mapgen.cpp
@@ -763,16 +763,6 @@ void MapgenBasic::generateBiomes()
 
 			VoxelArea::add_y(em, vi, -1);
 		}
-		// If no stone surface was detected in this mapchunk column the biomemap
-		// will be empty for this (x, z) position. Add the currently active
-		// biome to the biomemap, or if biome is NULL calculate it for this
-		// position and add it.
-		if (biomemap[index] == BIOME_NONE) {
-			if (!biome)
-				biome = biomegen->getBiomeAtIndex(
-					index, v3s16(x, node_min.Y, z));
-			biomemap[index] = biome->index;
-		}
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -763,16 +763,6 @@ void MapgenBasic::generateBiomes()`
`763`	`763`
`764`	`764`	`VoxelArea::add_y(em, vi, -1);`
`765`	`765`	`}`
`766`		`- // If no stone surface was detected in this mapchunk column the biomemap`
`767`		`- // will be empty for this (x, z) position. Add the currently active`
`768`		`- // biome to the biomemap, or if biome is NULL calculate it for this`
`769`		`- // position and add it.`
`770`		`- if (biomemap[index] == BIOME_NONE) {`
`771`		`- if (!biome)`
`772`		`- biome = biomegen->getBiomeAtIndex(`
`773`		`- index, v3s16(x, node_min.Y, z));`
`774`		`- biomemap[index] = biome->index;`
`775`		`- }`
`776`	`766`	`}`
`777`	`767`	`}`
`778`	`768`