Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensmtpd package and module: add nixos test #42326

Merged
merged 1 commit into from Jun 29, 2018
Merged

opensmtpd package and module: add nixos test #42326

merged 1 commit into from Jun 29, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Jun 21, 2018 •
edited

Motivation for this change

This adds a test for OpenSMTPD + dovecot, making failures less likely, even though it looks like it wouldn't have detected the breakage introduced by the dovecot bump that caused the need for #42139.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg test opensmtpd

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.opensmtpd

Partial log (click to expand)

smtp1: running command: sync
smtp1: exit status 0
test script finished in 37.51s
cleaning up
killing smtp2 (pid 593)
killing client (pid 605)
killing smtp1 (pid 617)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/l6wad5027wvrm00297i5i3jrfiy7skii-vm-test-run-opensmtpd

@matthewbauer matthewbauer merged commit ba0cd50 into NixOS:master Jun 29, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.opensmtpd

Partial log (click to expand)

smtp2: running command: sync
smtp2: exit status 0
test script finished in 24.45s
cleaning up
killing client (pid 627)
killing smtp1 (pid 640)
killing smtp2 (pid 653)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/x33jrv0nys30vk7z3rpx3gcflgm99wjv-vm-test-run-opensmtpd

@obadz
Copy link
Contributor

obadz commented Jun 29, 2018

Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ekleog @matthewbauer @GrahamcOfBorg @obadz