Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdigidoc: 3.10.1.1212 -> 3.10.4, libdigidocpp: 3.13.3.1365 -> 3.13.6, remove qdigidoc #42321

Closed
wants to merge 3 commits into from
Closed

libdigidoc: 3.10.1.1212 -> 3.10.4, libdigidocpp: 3.13.3.1365 -> 3.13.6, remove qdigidoc #42321

wants to merge 3 commits into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 21, 2018

Motivation for this change

Package were discovered as broken during a review of a different pull request.
qdigidoc is queued for removal unless an active maintainer is found: cc @jagajaga

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
libdigidoc: 3.10.1.1212 -> 3.10.4
5c424f3
@Mic92
libdigidocpp: 3.13.3.1365 -> 3.13.6
d617266
@Mic92
qdigidoc: remove due lack of maintenance
620af18 
Package fails to build and maintainer did not updated this package since
two years.
@Mic92 Mic92 changed the title libdigidoc: update, remove qdigidoc libdigidoc: 3.10.1.1212 -> 3.10.4, libdigidocpp: 3.13.3.1365 -> 3.13.6, remove qdigidoc Jun 21, 2018
@Mic92
Copy link
Member Author

Mic92 commented Jun 21, 2018

@GrahamcOfBorg build libdigidocpp

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: libdigidocpp

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libdigidocpp

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l7xailx5m5nz4drfv6lmjprdh1ig2h7y-libdigidocpp-3.13.6
shrinking /nix/store/l7xailx5m5nz4drfv6lmjprdh1ig2h7y-libdigidocpp-3.13.6/bin/digidoc-tool
shrinking /nix/store/l7xailx5m5nz4drfv6lmjprdh1ig2h7y-libdigidocpp-3.13.6/lib/libdigidocpp.so.3.13.6
gzipping man pages under /nix/store/l7xailx5m5nz4drfv6lmjprdh1ig2h7y-libdigidocpp-3.13.6/share/man/
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l7xailx5m5nz4drfv6lmjprdh1ig2h7y-libdigidocpp-3.13.6/lib  /nix/store/l7xailx5m5nz4drfv6lmjprdh1ig2h7y-libdigidocpp-3.13.6/bin
patching script interpreter paths in /nix/store/l7xailx5m5nz4drfv6lmjprdh1ig2h7y-libdigidocpp-3.13.6
checking for references to /build in /nix/store/l7xailx5m5nz4drfv6lmjprdh1ig2h7y-libdigidocpp-3.13.6...
/nix/store/l7xailx5m5nz4drfv6lmjprdh1ig2h7y-libdigidocpp-3.13.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libdigidocpp

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/y5czb86w4qi7v22habbi0fcqzb3f8pv1-libdigidocpp-3.13.6
shrinking /nix/store/y5czb86w4qi7v22habbi0fcqzb3f8pv1-libdigidocpp-3.13.6/bin/digidoc-tool
shrinking /nix/store/y5czb86w4qi7v22habbi0fcqzb3f8pv1-libdigidocpp-3.13.6/lib/libdigidocpp.so.3.13.6
gzipping man pages under /nix/store/y5czb86w4qi7v22habbi0fcqzb3f8pv1-libdigidocpp-3.13.6/share/man/
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y5czb86w4qi7v22habbi0fcqzb3f8pv1-libdigidocpp-3.13.6/lib  /nix/store/y5czb86w4qi7v22habbi0fcqzb3f8pv1-libdigidocpp-3.13.6/bin
patching script interpreter paths in /nix/store/y5czb86w4qi7v22habbi0fcqzb3f8pv1-libdigidocpp-3.13.6
checking for references to /build in /nix/store/y5czb86w4qi7v22habbi0fcqzb3f8pv1-libdigidocpp-3.13.6...
/nix/store/y5czb86w4qi7v22habbi0fcqzb3f8pv1-libdigidocpp-3.13.6

jagajaga
jagajaga reviewed Jun 21, 2018
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -4650,7 +4650,6 @@ with pkgs;
qastools = libsForQt5.callPackage ../tools/audio/qastools { };

qesteidutil = libsForQt5.callPackage ../tools/security/qesteidutil { } ;
qdigidoc = libsForQt5.callPackage ../tools/security/qdigidoc { } ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to mark it as broken instead of removing.

Copy link
Member Author

@Mic92 Mic92 Jun 21, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we spend time on evaluation of derivations that have not seen any updates since 2016? Also it removes a large patch from the channel.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libdigidoc, libdigidocpp

Partial log (click to expand)

/nix/store/nq4v0jkqvyib64cy2scgbalr480lylsg-libdigidoc-3.10.4
/nix/store/l7xailx5m5nz4drfv6lmjprdh1ig2h7y-libdigidocpp-3.13.6

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: libdigidoc, libdigidocpp

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libdigidoc, libdigidocpp

Partial log (click to expand)

/nix/store/5d8kkwghll0cdrf2dn896a3qv366fpsq-libdigidoc-3.10.4
/nix/store/y5czb86w4qi7v22habbi0fcqzb3f8pv1-libdigidocpp-3.13.6

@Mic92 Mic92 mentioned this pull request Jun 21, 2018
Closed
@lukateras
Copy link
Member

I'm interested in maintaining qdigidoc, I'll send a pull request with an update and maintainership claim soon.

@Mic92
Copy link
Member Author

Mic92 commented Jun 26, 2018

@yegortimoshenko any updates on this?

@lukateras lukateras mentioned this pull request Jul 5, 2018
Merged
@Mic92 Mic92 closed this Jul 8, 2018
@Mic92 Mic92 deleted the digidoc branch July 8, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga jagajaga left review comments

Assignees
No one assigned
Labels
8.has: clean-up 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @GrahamcOfBorg @lukateras @jagajaga