Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avidemux: 2.7.0 -> 2.7.1 #42218

Merged
merged 1 commit into from Jun 19, 2018
Merged

avidemux: 2.7.0 -> 2.7.1 #42218

merged 1 commit into from Jun 19, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 19, 2018 •
edited

Motivation for this change

The current version of avidemux (v2.7.0) breaks on master (see
https://hydra.nixos.org/build/75993794), the 18.03 build remains fine
(https://hydra.nixos.org/build/75935027).

The following changes have been applied:

  • glibc compat patch is obsolete as it landed in upstream.

  • Fixed QT_PLUGIN_PATH for QT binaries to avoid errors because of
    missing plugins like this:

    qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

[1]    20081 abort      /nix/store/rjwxc6ih15zwvvy71ss8bvnh56ibfbmj-avidemux-2.7.1/bin/avidemux3_qt5
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
avidemux: 2.7.0 -> 2.7.1
d2f623d 
The current version of `avidemux` (v2.7.0) breaks on master (see
https://hydra.nixos.org/build/75993794), the 18.03 build remains fine
(https://hydra.nixos.org/build/75935027).

The following changes have been applied:

* `glibc` compat patch is obsolete as it landed in upstream.

* Fixed QT_PLUGIN_PATH for QT binaries to avoid errors because of
  missing plugins like this:

  ```
  qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
  This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

  [1]    20081 abort      /nix/store/rjwxc6ih15zwvvy71ss8bvnh56ibfbmj-avidemux-2.7.1/bin/avidemux3_qt5
  ```
@adisbladis
Copy link
Member

@GrahamcOfBorg eval

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: avidemux

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: avidemux

Partial log (click to expand)

shrinking /nix/store/z2nf1vfvs180wv7dwm6d0c62r0bczjjq-avidemux-2.7.1/lib64/libADM_coreAudioDevice6.so
shrinking /nix/store/z2nf1vfvs180wv7dwm6d0c62r0bczjjq-avidemux-2.7.1/bin/.avidemux3_cli-wrapped
shrinking /nix/store/z2nf1vfvs180wv7dwm6d0c62r0bczjjq-avidemux-2.7.1/bin/.avidemux3_qt5-wrapped
shrinking /nix/store/z2nf1vfvs180wv7dwm6d0c62r0bczjjq-avidemux-2.7.1/bin/.avidemux3_jobs_qt5-wrapped
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z2nf1vfvs180wv7dwm6d0c62r0bczjjq-avidemux-2.7.1/lib64  /nix/store/z2nf1vfvs180wv7dwm6d0c62r0bczjjq-avidemux-2.7.1/bin
patching script interpreter paths in /nix/store/z2nf1vfvs180wv7dwm6d0c62r0bczjjq-avidemux-2.7.1
checking for references to /build in /nix/store/z2nf1vfvs180wv7dwm6d0c62r0bczjjq-avidemux-2.7.1...
moving /nix/store/z2nf1vfvs180wv7dwm6d0c62r0bczjjq-avidemux-2.7.1/lib64/* to /nix/store/z2nf1vfvs180wv7dwm6d0c62r0bczjjq-avidemux-2.7.1/lib
/nix/store/z2nf1vfvs180wv7dwm6d0c62r0bczjjq-avidemux-2.7.1

@fpletz fpletz merged commit 963de45 into NixOS:master Jun 19, 2018
@Ma27 Ma27 deleted the bump-avidemux branch June 19, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @adisbladis @GrahamcOfBorg @fpletz