nix-update-source: 0.5.0 -> 0.6.3 #42220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jun 19, 2018
| name = "nix-update-source-${version}"; | ||
| src = fetchFromGitHub { | ||
| owner = "timbertson"; | ||
| repo = "nix-update-source"; | ||
| rev = "version-0.5.0"; | ||
| sha256 = "13icwk249frddsmn9albasikwp8asmgvp3jf9xj9adzh63wzh1i7"; | ||
| rev = "version-0.6.3"; |
There was a problem hiding this comment.
Can you make this a variable? rev = "version-${version}";?
|
Not easily - this field is written by a script (note the updateScript
attribute)
…On Tue., 19 Jun. 2018, 11:04 pm Jörg Thalheim, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/tools/package-management/nix-update-source/default.nix
<#42220 (comment)>:
> name = "nix-update-source-${version}";
src = fetchFromGitHub {
owner = "timbertson";
repo = "nix-update-source";
- rev = "version-0.5.0";
- sha256 = "13icwk249frddsmn9albasikwp8asmgvp3jf9xj9adzh63wzh1i7";
+ rev = "version-0.6.3";
Can you make this a variable? rev = "version-${version}";?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#42220 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA3XB5GcZ89Z48dNgUzYaeW6QVl4L5zks5t-PbJgaJpZM4UtOc0>
.
|
|
The script is not capable of ignore this field? |
|
No, it generates the entire |
|
Just reduces the noise within the commit log a little bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)