Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreutils: 8.29 -> 8.30 #42880

Merged
merged 1 commit into from Sep 1, 2018
Merged

coreutils: 8.29 -> 8.30 #42880

merged 1 commit into from Sep 1, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 2, 2018 •
edited

http://savannah.gnu.org/forum/forum.php?forum_id=9187

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jul 2, 2018

Whoops, tests fail on x86_64-unknown-linux-gnu (and perhaps others?).

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: coreutils

Partial log (click to expand)

Makefile:12212: recipe for target 'check-am' failed
make[2]: *** [check-am] Error 2
make[2]: Leaving directory '/build/coreutils-8.30'
Makefile:11737: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory '/build/coreutils-8.30'
Makefile:12214: recipe for target 'check' failed
make: *** [check] Error 2
builder for '/nix/store/amk03bf7vdxmg1fckw9zdajpfpybpwsg-coreutils-8.30.drv' failed with exit code 2
error: build of '/nix/store/amk03bf7vdxmg1fckw9zdajpfpybpwsg-coreutils-8.30.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: coreutils

Partial log (click to expand)

make[4]: Leaving directory '/build/coreutils-8.30'
make[3]: *** [Makefile:11960: check-TESTS] Error 2
make[3]: Leaving directory '/build/coreutils-8.30'
make[2]: *** [Makefile:12212: check-am] Error 2
make[2]: Leaving directory '/build/coreutils-8.30'
make[1]: *** [Makefile:11737: check-recursive] Error 1
make[1]: Leaving directory '/build/coreutils-8.30'
make: *** [Makefile:12214: check] Error 2
builder for '/nix/store/ll472da4kzi3qyjg4zf0lc2w0ich0358-coreutils-8.30.drv' failed with exit code 2
error: build of '/nix/store/ll472da4kzi3qyjg4zf0lc2w0ich0358-coreutils-8.30.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: coreutils

Partial log (click to expand)

cannot build derivation '/nix/store/m01an5vj3x47bhhz01fbw9dhxvw8gihf-adv_cmds-osx-10.5.8.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/r2a57gw2h555rqgnj2m1b8zd31sgp83s-binutils-wrapper-2.30.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/w4pic5lqay2pch4bgcbj549aqvb9nhqw-bash-4.4-p23.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/6nyr88ky36jgdbj42s4g4xrwwh060qq4-bootstrap-stage3-binutils-wrapper.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/9fqpfvd5gc656wdngv2j7kxfahxll5n4-bootstrap-stage3-clang-wrapper.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/l1p27sjncm33jczmii8spvdnxb9pafq8-bootstrap-stage3-stdenv-darwin.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/w9pjfclzfb24lk9bzqa5vcyaay439p63-gmp-6.1.2.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/pxzfpqm16bkk8cz1rcr3v2ic7hxs6icb-xz-5.2.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/5kg9h28zysiscdz4fbnld6b97j9s3d7d-coreutils-8.30.drv': 4 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/5kg9h28zysiscdz4fbnld6b97j9s3d7d-coreutils-8.30.drv' failed

@dtzWill
Copy link
Member Author

dtzWill commented Jul 4, 2018

Bah, anyone know what's going on with env-S.pl?

@xeji
Copy link
Contributor

xeji commented Aug 2, 2018

Bah, anyone know what's going on with env-S.pl?

Not yet but I just found out that the tests pass with sandboxing disabled, so at least we have a hint what to look for.

@xeji
Copy link
Contributor

xeji commented Aug 3, 2018

The env -S option and corresponding env-S.pl test were newly added in coreultils 8.30.

vcunat added a commit that referenced this pull request Aug 30, 2018
@vcunat
Merge #42880: libinput: split .bin output
6f2f91f
@vcunat vcunat merged commit 7f308aa into NixOS:staging Sep 1, 2018
vcunat added a commit that referenced this pull request Sep 1, 2018
@vcunat
coreutils: disable a new test for now
cbd9262 
As discussed in #42880, this test and functionality is new,
and apparently noone will look deeper for now.
vcunat added a commit that referenced this pull request Sep 1, 2018
@vcunat
Merge #42880: coreutils: 8.29 -> 8.30
edc13ba
@xeji
Copy link
Contributor

xeji commented Sep 1, 2018 via email

@vcunat
Copy link
Member

vcunat commented Sep 1, 2018

Yes, I disabled the test.

@vcunat
Copy link
Member

vcunat commented Sep 1, 2018 •
edited

Eww, but it broke generation of new stdenv bootstrap tools :-/ EDIT: confirmed on all *-linux by Hydra https://hydra.nixos.org/build/80578414

@xeji
Copy link
Contributor

xeji commented Sep 1, 2018

let's revert, this is too risky one day before branch-off

@vcunat
Copy link
Member

vcunat commented Sep 1, 2018

Staging has no chance to get to master that fast anyway.

@vcunat
Copy link
Member

vcunat commented Sep 1, 2018

Even so, if I don't see a solution tomorrow, I'll revert it.

vcunat added a commit that referenced this pull request Sep 3, 2018
@vcunat
Revert "Merge #42880: coreutils: 8.29 -> 8.30"
e3ee9c0 
This reverts commit edc13ba, reversing
changes made to 90464f6.
Bootstrap tools generation is broken, and I don't know why yet.
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Sep 23, 2018
@dtzWill
Revert "Revert "Merge NixOS#42880: coreutils: 8.29 -> 8.30""
095ef62 
This reverts commit e3ee9c0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @xeji @vcunat