Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zotero: Fix #42881

Merged
merged 1 commit into from Jul 2, 2018
Merged

Zotero: Fix #42881

merged 1 commit into from Jul 2, 2018

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Jul 2, 2018 •
edited by dotlambda

Motivation for this change

Fixes #42110

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda merged commit 5b4beca into NixOS:master Jul 2, 2018
@infinisil infinisil deleted the fix/zotero branch July 3, 2018 05:47
@infinisil infinisil restored the fix/zotero branch July 5, 2018 23:39
@infinisil infinisil deleted the fix/zotero branch July 5, 2018 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@infinisil @dotlambda @GrahamcOfBorg