Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rPackages.rhdf5: fix installation #42879

Merged
merged 1 commit into from Jul 3, 2018
Merged

rPackages.rhdf5: fix installation #42879

merged 1 commit into from Jul 3, 2018

Conversation

iimog
Copy link
Member

@iimog iimog commented Jul 2, 2018

Fix #42878

Motivation for this change

Fix installation of rPackages.rhdf5. This affects multiple other packages as they depend on rhdf5 directly or indirectly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@iimog iimog requested a review from peti as a code owner July 2, 2018 16:55
@Mic92
Copy link
Member

Mic92 commented Jul 3, 2018

@GrahamcOfBorg build rPackages.rhdf5

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rPackages.rhdf5

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rPackages.rhdf5

Partial log (click to expand)

** testing if installed package can be loaded
* DONE (rhdf5)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/54dj5pz536lscqcc86ynvwq140dk6vdz-r-rhdf5-2.22.0
shrinking /nix/store/54dj5pz536lscqcc86ynvwq140dk6vdz-r-rhdf5-2.22.0/library/rhdf5/libs/rhdf5.so
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/54dj5pz536lscqcc86ynvwq140dk6vdz-r-rhdf5-2.22.0
/nix/store/54dj5pz536lscqcc86ynvwq140dk6vdz-r-rhdf5-2.22.0/library/rhdf5/downloadHDF5/downloadHDF5.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/54dj5pz536lscqcc86ynvwq140dk6vdz-r-rhdf5-2.22.0...
/nix/store/54dj5pz536lscqcc86ynvwq140dk6vdz-r-rhdf5-2.22.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rPackages.rhdf5

Partial log (click to expand)

*** installing help indices
** building package indices
** installing vignettes
** testing if installed package can be loaded
* DONE (rhdf5)
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/krw9lw4qh0si61fmlk9fmn42lj7wdrib-r-rhdf5-2.22.0
/nix/store/krw9lw4qh0si61fmlk9fmn42lj7wdrib-r-rhdf5-2.22.0/library/rhdf5/downloadHDF5/downloadHDF5.sh: interpreter directive changed from "/bin/bash" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash"
/nix/store/krw9lw4qh0si61fmlk9fmn42lj7wdrib-r-rhdf5-2.22.0

@Mic92 Mic92 merged commit 6421995 into NixOS:master Jul 3, 2018
@iimog iimog mentioned this pull request Jul 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iimog @Mic92 @GrahamcOfBorg