Add Brother MFC-L2740DW drivers #42905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
requested changes
Jul 3, 2018
| phases = [ "installPhase" ]; | ||
|
|
||
| installPhase = '' | ||
| dpkg-deb -x $src $out |
There was a problem hiding this comment.
Use unpackPhase = "dpkg-deb -x $src $out" instead, setting phases explicitly should be avoided if possible. Also applies to the other derivation.
| @@ -0,0 +1,45 @@ | |||
| { pkgs, stdenv, fetchurl, dpkg, makeWrapper, coreutils, ghostscript, gnugrep, gnused, which, perl }: | |||
There was a problem hiding this comment.
You can take the pkgsi686Linux argument here directly to not have to use pkgs
Brother MFC-L2740DW lpr driver
CUPS wrapper for Brother MFC-L2740DW
infinisil
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add drivers for Brother MFC-L2740DW printers
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)