Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avocode: 3.0.0 -> 3.1.1 #42808

Merged
merged 1 commit into from Jun 30, 2018
Merged

avocode: 3.0.0 -> 3.1.1 #42808

merged 1 commit into from Jun 30, 2018

Conversation

megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented Jun 30, 2018 •
edited

Motivation for this change

Upgrade avocode to 3.1.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 30, 2018

unfree package, build tested locally.

@xeji xeji merged commit c9f9ec6 into NixOS:master Jun 30, 2018
@megheaiulian megheaiulian deleted the feature/avocode-3.1.0 branch July 21, 2018 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@megheaiulian @xeji @GrahamcOfBorg