Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distrobuilder: 2018_04_28 -> 2018_06_29 #42810

Merged
merged 2 commits into from Jun 30, 2018
Merged

distrobuilder: 2018_04_28 -> 2018_06_29 #42810

merged 2 commits into from Jun 30, 2018

Conversation

megheaiulian
Copy link
Contributor

Motivation for this change

Upgrade distrobuilder and add add doCheck.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 30, 2018

@GrahamcOfBorg build distrobuilder

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: distrobuilder

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: distrobuilder

Partial log (click to expand)

2018/06/30 11:59:40 Running test #2: variable not in context
2018/06/30 11:59:40 Running test #3: invalid template
2018/06/30 11:59:40 Running test #4: invalid context
--- PASS: TestRenderTemplate (0.00s)
=== RUN   TestSetEnvVariables
--- PASS: TestSetEnvVariables (0.00s)
FAIL
FAIL    github.com/lxc/distrobuilder/shared     2.062s
builder for '/nix/store/3p5nw6b9zq7vm9lbkd0m0qkvqw7gpl5l-distrobuilder-2018_06_29.drv' failed with exit code 1
error: build of '/nix/store/3p5nw6b9zq7vm9lbkd0m0qkvqw7gpl5l-distrobuilder-2018_06_29.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: distrobuilder

Partial log (click to expand)

2018/06/30 11:56:48 Running test #2: variable not in context
2018/06/30 11:56:48 Running test #3: invalid template
2018/06/30 11:56:48 Running test #4: invalid context
--- PASS: TestRenderTemplate (0.00s)
=== RUN   TestSetEnvVariables
--- PASS: TestSetEnvVariables (0.00s)
FAIL
FAIL    github.com/lxc/distrobuilder/shared     2.399s
builder for '/nix/store/6svknq4q8pw9b05idnldvv3inc01rff4-distrobuilder-2018_06_29.drv' failed with exit code 1
error: build of '/nix/store/6svknq4q8pw9b05idnldvv3inc01rff4-distrobuilder-2018_06_29.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 30, 2018 

        util_test.go:87: Failed to verify: testfile with detached signature
                Failed to create keyring: gpg: keybox '/build/distrobuilder.713647054/pubring.kbx' created
                gpg: keyserver receive failed: No such file or directory

Looks like the test fails in the sandbox because it tries to download a key from a keyserver. No network access in the sandbox. You can try to pre-download the key with fetchurl during build or disable the failing test. If this doesn't help, disable tests altogether again.

I recommend to enable sandboxing on your system because it's safer, and it will help you catch these errors.

@megheaiulian
Copy link
Contributor Author

megheaiulian commented Jun 30, 2018 •
edited

@xeji I've disable tests for now.
I was testing locally using nix-build -A distrobuilder --show-trace --option build-use-sandbox true but I didn't catch any of the problems with tests. Will retry to keep tests on a next update.

@megheaiulian
Copy link
Contributor Author

@GrahamcOfBorg build distrobuilder

1 similar comment
@xeji
Copy link
Contributor

xeji commented Jun 30, 2018

@GrahamcOfBorg build distrobuilder

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: distrobuilder

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: distrobuilder

Partial log (click to expand)

shrinking /nix/store/6aazmp6khmdj5zr6xs1vmrvqir5i7myv-distrobuilder-2018_06_29-bin/bin/.distrobuilder-wrapped
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6aazmp6khmdj5zr6xs1vmrvqir5i7myv-distrobuilder-2018_06_29-bin/bin
patching script interpreter paths in /nix/store/6aazmp6khmdj5zr6xs1vmrvqir5i7myv-distrobuilder-2018_06_29-bin
checking for references to /build in /nix/store/6aazmp6khmdj5zr6xs1vmrvqir5i7myv-distrobuilder-2018_06_29-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/2i41giz1i8fnljjzzr8rcnzw57iqckf6-distrobuilder-2018_06_29
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2i41giz1i8fnljjzzr8rcnzw57iqckf6-distrobuilder-2018_06_29
checking for references to /build in /nix/store/2i41giz1i8fnljjzzr8rcnzw57iqckf6-distrobuilder-2018_06_29...
/nix/store/6aazmp6khmdj5zr6xs1vmrvqir5i7myv-distrobuilder-2018_06_29-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: distrobuilder

Partial log (click to expand)

shrinking /nix/store/0sk8jscgh6k2js85mn2yigzyggwwy0mw-distrobuilder-2018_06_29-bin/bin/.distrobuilder-wrapped
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0sk8jscgh6k2js85mn2yigzyggwwy0mw-distrobuilder-2018_06_29-bin/bin
patching script interpreter paths in /nix/store/0sk8jscgh6k2js85mn2yigzyggwwy0mw-distrobuilder-2018_06_29-bin
checking for references to /build in /nix/store/0sk8jscgh6k2js85mn2yigzyggwwy0mw-distrobuilder-2018_06_29-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/qxcjqs2j9yvkrq9y3zqngnf71mpc9cmg-distrobuilder-2018_06_29
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/qxcjqs2j9yvkrq9y3zqngnf71mpc9cmg-distrobuilder-2018_06_29
checking for references to /build in /nix/store/qxcjqs2j9yvkrq9y3zqngnf71mpc9cmg-distrobuilder-2018_06_29...
/nix/store/0sk8jscgh6k2js85mn2yigzyggwwy0mw-distrobuilder-2018_06_29-bin

@xeji xeji merged commit 66e18c3 into NixOS:master Jun 30, 2018
@megheaiulian megheaiulian deleted the feature/distrobuilder branch July 21, 2018 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@megheaiulian @xeji @GrahamcOfBorg