Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.matrix-client: 0.2.0 -> 0.3.2 #42915

Merged
merged 1 commit into from Jul 6, 2018
Merged

pythonPackages.matrix-client: 0.2.0 -> 0.3.2 #42915

merged 1 commit into from Jul 6, 2018

Conversation

peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Jul 3, 2018 •
edited

Motivation for this change

Update and rename (it's matrix_client on pypi, not matrix-client).

Tests are ~~~running~~~ done.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg requested a review from FRidh as a code owner July 3, 2018 14:27
@peterhoeg peterhoeg changed the title pythonPackages.matrix-client: 0.2.0 -> 0.3.2 WIP pythonPackages.matrix-client: 0.2.0 -> 0.3.2 Jul 3, 2018
@peterhoeg
Copy link
Member Author

Cc @FRidh @dotlambda

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.matrix-client python3.pkgs.matrix-client

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.matrix-client, python3.pkgs.matrix-client

Partial log (click to expand)

platform linux -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/matrix_client-0.3.2, inifile: setup.cfg
collected 37 items

test/api_test.py ..................                                      [ 48%]
test/client_test.py ...................                                  [100%]

========================== 37 passed in 0.71 seconds ===========================
/nix/store/i6gn8j3fx4ff31w3558jiynrickgn867-python2.7-matrix_client-0.3.2
/nix/store/pfbh8ip5n2ihikhscajrircv7xmbslgr-python3.6-matrix_client-0.3.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.matrix-client, python3.pkgs.matrix-client

Partial log (click to expand)

platform linux -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/matrix_client-0.3.2, inifile: setup.cfg
collected 37 items

test/api_test.py ..................                                      [ 48%]
test/client_test.py ...................                                  [100%]

========================== 37 passed in 2.50 seconds ===========================
/nix/store/nnj59f0xymsf399w1ccr7qbj2bmgcvv0-python2.7-matrix_client-0.3.2
/nix/store/fs2mf4bf3gdrnm2sxy483nv7p1gp3kab-python3.6-matrix_client-0.3.2

@peterhoeg
Copy link
Member Author

I already tested it with nox-review and it's all good.

dotlambda
dotlambda reviewed Jul 3, 2018
View reviewed changes
pkgs/development/python-modules/matrix-client/default.nix Outdated
@@ -2,19 +2,19 @@
, buildPythonPackage
, fetchPypi
, requests
, tox, pytest, flake8, responses
, flake8, pytest, pytestrunner, responses, tox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure tox isn't needed.

@dotlambda
Copy link
Member

I already tested it with nox-review and it's all good.

You know there's nix-review? :)

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.matrix-client python3.pkgs.matrix-client

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.matrix-client, python3.pkgs.matrix-client

Partial log (click to expand)

platform linux -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/matrix_client-0.3.2, inifile: setup.cfg
collected 37 items

test/api_test.py ..................                                      [ 48%]
test/client_test.py ...................                                  [100%]

========================== 37 passed in 0.86 seconds ===========================
/nix/store/dzkh19pf60lggp3ci837iqp7z0l3x58w-python2.7-matrix_client-0.3.2
/nix/store/f4kihzv43i7zmcd6vllmw9ddpjzj2w9g-python3.6-matrix_client-0.3.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.matrix-client, python3.pkgs.matrix-client

Partial log (click to expand)

platform linux -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/matrix_client-0.3.2, inifile: setup.cfg
collected 37 items

test/api_test.py ..................                                      [ 48%]
test/client_test.py ...................                                  [100%]

========================== 37 passed in 2.36 seconds ===========================
/nix/store/h155ry8hgy66ylksi3jvhpd45yz3z7pq-python2.7-matrix_client-0.3.2
/nix/store/iifhy2ip24wzlxq4k3hb2nci6pimmvxf-python3.6-matrix_client-0.3.2

@dotlambda dotlambda merged commit 9a066a3 into NixOS:master Jul 6, 2018
@peterhoeg
Copy link
Member Author

peterhoeg commented Jul 9, 2018 via email •
edited

@peterhoeg peterhoeg deleted the u/matrix branch July 9, 2018 07:11
@dotlambda
Copy link
Member

No, not wip but you can give it a local commit using rev.

@peterhoeg
Copy link
Member Author

I found rev. My guess is that wip isn't possible due to the use of git work trees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @dotlambda @GrahamcOfBorg