Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: b49022fcd0ff
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: bf5710cd7e3e
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jul 27, 2018

  1. [haskell/generic-builder] windows always has an active library 

    This commit is not really correct. The `hasActiveLibrary` check is wrong.
We can have an active library even if we do not ask for a static lirbary or
dynamic one; we can still have just a set of objet files and archives.
    @angerman @ryantm
    angerman authored and ryantm committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    61436e7 View commit details
    Browse the repository at this point in the history

  2. Update generic-builder.nix 

    Drop `hasActiveLibrary` altogether. The condition is wrong, `isLibrary` is the correct one. We can have non-static, non-shared libraries as well.
    @angerman @ryantm
    angerman authored and ryantm committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    bf5710c View commit details
    Browse the repository at this point in the history