Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sabyenc: init at 2.3.3 #44152

Merged
merged 2 commits into from Jul 28, 2018
Merged

pythonPackages.sabyenc: init at 2.3.3 #44152

merged 2 commits into from Jul 28, 2018

Conversation

georgewhewell
Copy link
Contributor

Motivation for this change

sabnzbd has started complaining about missing sabyenc module (which apparently offers better performance), so package it and add to sabnzbd dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@georgewhewell georgewhewell force-pushed the add-sabyenc branch 2 times, most recently from 372a063 to 1b44167 Compare July 27, 2018 15:37
@ryantm
Copy link
Member

ryantm commented Jul 28, 2018

@GrahamcOfBorg build python2.pkgs.sabyenc python3.pkgs.sabyenc sabnzbd

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.sabyenc, python3.pkgs.sabyenc

The following builds were skipped because they don't evaluate on aarch64-linux: sabnzbd

Partial log (click to expand)

/build/sabyenc-3.3.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/j2zx8b96i17nx3rshshnb8rc3vdyic1q-python3.6-sabyenc-3.3.5
shrinking /nix/store/j2zx8b96i17nx3rshshnb8rc3vdyic1q-python3.6-sabyenc-3.3.5/lib/python3.6/site-packages/sabyenc.cpython-36m-aarch64-linux-gnu.so
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j2zx8b96i17nx3rshshnb8rc3vdyic1q-python3.6-sabyenc-3.3.5/lib
patching script interpreter paths in /nix/store/j2zx8b96i17nx3rshshnb8rc3vdyic1q-python3.6-sabyenc-3.3.5
checking for references to /build in /nix/store/j2zx8b96i17nx3rshshnb8rc3vdyic1q-python3.6-sabyenc-3.3.5...
/nix/store/pbdz2ns50ayai7jl82l4v7ljz9ml2c63-python2.7-sabyenc-3.3.5
/nix/store/j2zx8b96i17nx3rshshnb8rc3vdyic1q-python3.6-sabyenc-3.3.5

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.sabyenc, python3.pkgs.sabyenc

The following builds were skipped because they don't evaluate on x86_64-darwin: sabnzbd

Partial log (click to expand)

Processing ./sabyenc-3.3.5-cp36-cp36m-macosx_10_6_x86_64.whl
Installing collected packages: sabyenc
Successfully installed sabyenc-3.3.5
/private/tmp/nix-build-python3.6-sabyenc-3.3.5.drv-0/sabyenc-3.3.5
post-installation fixup
strip is /nix/store/sixx1lfy97125f6hxymbwn64cb8z62p3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ac5w1h7fp43hzr29xqj9w12vrh7h29w5-python3.6-sabyenc-3.3.5/lib
patching script interpreter paths in /nix/store/ac5w1h7fp43hzr29xqj9w12vrh7h29w5-python3.6-sabyenc-3.3.5
/nix/store/3m3ix24g7yl294zw1xxla49fa9zjichc-python2.7-sabyenc-3.3.5
/nix/store/ac5w1h7fp43hzr29xqj9w12vrh7h29w5-python3.6-sabyenc-3.3.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.sabyenc, python3.pkgs.sabyenc

The following builds were skipped because they don't evaluate on x86_64-linux: sabnzbd

Partial log (click to expand)

/build/sabyenc-3.3.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jxxrl37acz0b802gqsfhv2z78gal55ba-python3.6-sabyenc-3.3.5
shrinking /nix/store/jxxrl37acz0b802gqsfhv2z78gal55ba-python3.6-sabyenc-3.3.5/lib/python3.6/site-packages/sabyenc.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jxxrl37acz0b802gqsfhv2z78gal55ba-python3.6-sabyenc-3.3.5/lib
patching script interpreter paths in /nix/store/jxxrl37acz0b802gqsfhv2z78gal55ba-python3.6-sabyenc-3.3.5
checking for references to /build in /nix/store/jxxrl37acz0b802gqsfhv2z78gal55ba-python3.6-sabyenc-3.3.5...
/nix/store/9177wilyw583pg9hg4zkp1nw1qh7k8mx-python2.7-sabyenc-3.3.5
/nix/store/jxxrl37acz0b802gqsfhv2z78gal55ba-python3.6-sabyenc-3.3.5

@FRidh FRidh merged commit 5cd5e74 into NixOS:master Jul 28, 2018
@georgewhewell georgewhewell deleted the add-sabyenc branch July 28, 2018 18:06
@c0bw3b c0bw3b mentioned this pull request Oct 28, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@georgewhewell @ryantm @GrahamcOfBorg @FRidh