Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hnix: Fix build #44162

Merged
merged 1 commit into from Jul 27, 2018
Merged

hnix: Fix build #44162

merged 1 commit into from Jul 27, 2018

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

The hnix build was broken because the added patch could no longer be applied.
I believe it is included now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

I ran nox-review wip but it cannot complete because of #44156

@Profpatsch
Copy link
Member

@GrahamcOfBorg build haskellPackages.hnix

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.hnix

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.hnix

Partial log (click to expand)

strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i7smyjp4fi4yxk1r2spcs8i3dv9l6fms-hnix-0.5.2/lib  /nix/store/i7smyjp4fi4yxk1r2spcs8i3dv9l6fms-hnix-0.5.2/bin
patching script interpreter paths in /nix/store/i7smyjp4fi4yxk1r2spcs8i3dv9l6fms-hnix-0.5.2
checking for references to /build in /nix/store/i7smyjp4fi4yxk1r2spcs8i3dv9l6fms-hnix-0.5.2...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/xbb4qz8pj384mh75zxfj5zy4drmbw3vv-hnix-0.5.2-doc
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/xbb4qz8pj384mh75zxfj5zy4drmbw3vv-hnix-0.5.2-doc
checking for references to /build in /nix/store/xbb4qz8pj384mh75zxfj5zy4drmbw3vv-hnix-0.5.2-doc...
/nix/store/i7smyjp4fi4yxk1r2spcs8i3dv9l6fms-hnix-0.5.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskellPackages.hnix

Partial log (click to expand)

/nix/store/y06mk1hjnpy13g3ya775g6ylqb8g949c-hnix-0.5.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.2-GRObQNgD4K53WKtuuoSKVH-ghc8.4.3.dylib: fixing dylib
/nix/store/y06mk1hjnpy13g3ya775g6ylqb8g949c-hnix-0.5.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.2-GRObQNgD4K53WKtuuoSKVH-ghc8.4.3.dylib: fixing dylib
/nix/store/y06mk1hjnpy13g3ya775g6ylqb8g949c-hnix-0.5.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.2-GRObQNgD4K53WKtuuoSKVH-ghc8.4.3.dylib: fixing dylib
/nix/store/y06mk1hjnpy13g3ya775g6ylqb8g949c-hnix-0.5.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.2-GRObQNgD4K53WKtuuoSKVH-ghc8.4.3.dylib: fixing dylib
/nix/store/y06mk1hjnpy13g3ya775g6ylqb8g949c-hnix-0.5.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.2-GRObQNgD4K53WKtuuoSKVH-ghc8.4.3.dylib: fixing dylib
/nix/store/y06mk1hjnpy13g3ya775g6ylqb8g949c-hnix-0.5.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.2-GRObQNgD4K53WKtuuoSKVH-ghc8.4.3.dylib: fixing dylib
/nix/store/y06mk1hjnpy13g3ya775g6ylqb8g949c-hnix-0.5.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.2-GRObQNgD4K53WKtuuoSKVH-ghc8.4.3.dylib: fixing dylib
strip is /nix/store/sixx1lfy97125f6hxymbwn64cb8z62p3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/0jp95ab7ssd96af9nbl7gsnrmapcbqn9-hnix-0.5.2-doc
/nix/store/y06mk1hjnpy13g3ya775g6ylqb8g949c-hnix-0.5.2

@ryantm ryantm merged commit e7d5785 into NixOS:master Jul 27, 2018
@ryantm
Copy link
Member

ryantm commented Jul 27, 2018

Thanks!

@NeQuissimus NeQuissimus deleted the hnix_patch branch July 27, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@infinisil infinisil Awaiting requested review from infinisil

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
0.kind: enhancement 6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NeQuissimus @Profpatsch @GrahamcOfBorg @ryantm