Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ejabberd: 18.01 -> 18.06 #44158

Merged
merged 1 commit into from Aug 5, 2018
Merged

ejabberd: 18.01 -> 18.06 #44158

merged 1 commit into from Aug 5, 2018

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jul 27, 2018 •
edited

Motivation for this change

Version 18.06 was released approximately a month ago, see here for a changelog.

Packaging wise ejabberd switched from imagemagick to eimp, somewhere between 18.01 and 18.06. Eimp loads libpng, libjpeg and libwebp at runtime. These were therefore added as dependencies and
the relevant binary was wrapped to be able to find them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

If you can contact me on IRC, this package works.

@ajs124
ejabberd: 18.01 -> 18.06
34f96e9 
ejabberd switched from imagemagick to eimp, which loads libpng, libjpeg
and libwebp at runtime. These were therefore added as dependencies and
the relevant binary was wrapped to be able to find them.
@xeji
Copy link
Contributor

xeji commented Jul 29, 2018

@GrahamcOfBorg build ejabberd

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ejabberd

Partial log (click to expand)

shrinking /nix/store/cc0y12r1xj9h6p4ys9f9xk4n634kz246-ejabberd-18.06/lib/eimp-1.0.6/priv/bin/.eimp-wrapped
shrinking /nix/store/cc0y12r1xj9h6p4ys9f9xk4n634kz246-ejabberd-18.06/lib/cache_tab-1.0.14/priv/lib/ets_cache.so
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cc0y12r1xj9h6p4ys9f9xk4n634kz246-ejabberd-18.06/lib  /nix/store/cc0y12r1xj9h6p4ys9f9xk4n634kz246-ejabberd-18.06/bin  /nix/store/cc0y12r1xj9h6p4ys9f9xk4n634kz246-ejabberd-18.06/sbin
patching script interpreter paths in /nix/store/cc0y12r1xj9h6p4ys9f9xk4n634kz246-ejabberd-18.06
/nix/store/cc0y12r1xj9h6p4ys9f9xk4n634kz246-ejabberd-18.06/sbin/ejabberdctl: interpreter directive changed from "/bin/sh" to "/nix/store/6vqgi9d49smsbr2qxra52yhipg0yxf9f-bash-4.4-p23/bin/sh"
/nix/store/cc0y12r1xj9h6p4ys9f9xk4n634kz246-ejabberd-18.06/lib/ejabberd-18.06/priv/bin/captcha.sh: interpreter directive changed from "/bin/sh" to "/nix/store/6vqgi9d49smsbr2qxra52yhipg0yxf9f-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/cc0y12r1xj9h6p4ys9f9xk4n634kz246-ejabberd-18.06...
moving /nix/store/cc0y12r1xj9h6p4ys9f9xk4n634kz246-ejabberd-18.06/sbin/* to /nix/store/cc0y12r1xj9h6p4ys9f9xk4n634kz246-ejabberd-18.06/bin
/nix/store/cc0y12r1xj9h6p4ys9f9xk4n634kz246-ejabberd-18.06

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ejabberd

Partial log (click to expand)

shrinking /nix/store/sqpcrp95zjyx3vpdmra4gyl15xnyjgfm-ejabberd-18.06/lib/iconv-1.0.8/priv/lib/iconv.so
shrinking /nix/store/sqpcrp95zjyx3vpdmra4gyl15xnyjgfm-ejabberd-18.06/lib/stringprep-1.0.12/priv/lib/stringprep.so
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sqpcrp95zjyx3vpdmra4gyl15xnyjgfm-ejabberd-18.06/lib  /nix/store/sqpcrp95zjyx3vpdmra4gyl15xnyjgfm-ejabberd-18.06/bin  /nix/store/sqpcrp95zjyx3vpdmra4gyl15xnyjgfm-ejabberd-18.06/sbin
patching script interpreter paths in /nix/store/sqpcrp95zjyx3vpdmra4gyl15xnyjgfm-ejabberd-18.06
/nix/store/sqpcrp95zjyx3vpdmra4gyl15xnyjgfm-ejabberd-18.06/lib/ejabberd-18.06/priv/bin/captcha.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
/nix/store/sqpcrp95zjyx3vpdmra4gyl15xnyjgfm-ejabberd-18.06/sbin/ejabberdctl: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/sqpcrp95zjyx3vpdmra4gyl15xnyjgfm-ejabberd-18.06...
moving /nix/store/sqpcrp95zjyx3vpdmra4gyl15xnyjgfm-ejabberd-18.06/sbin/* to /nix/store/sqpcrp95zjyx3vpdmra4gyl15xnyjgfm-ejabberd-18.06/bin
/nix/store/sqpcrp95zjyx3vpdmra4gyl15xnyjgfm-ejabberd-18.06

@xeji
Copy link
Contributor

xeji commented Jul 29, 2018

cc maintainers @abbradar @svanderburg

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: ejabberd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@ajs124
Copy link
Member Author

ajs124 commented Aug 3, 2018

ping @abbradar @svanderburg

@xeji xeji merged commit 8910795 into NixOS:master Aug 5, 2018
@ajs124 ajs124 deleted the ejabberd_18_06 branch August 5, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @xeji @GrahamcOfBorg