Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.slackclient:1.0.0 -> 1.2.1 | refactor #44155

Merged
merged 1 commit into from Aug 1, 2018
Merged

pythonPackages.slackclient:1.0.0 -> 1.2.1 | refactor #44155

merged 1 commit into from Aug 1, 2018

Conversation

PsyanticY
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@PsyanticY PsyanticY requested a review from FRidh as a code owner July 27, 2018 16:22
@FRidh
Copy link
Member

FRidh commented Jul 28, 2018

@GrahamcOfBorg build pythonPackages.slackclient python3Packages.slackclient

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.slackclient, python3Packages.slackclient

Partial log (click to expand)

tests/test_channel.py .....                                              [ 26%]
tests/test_slackclient.py ......                                         [ 57%]
tests/test_slackrequest.py ........                                      [100%]



========================== 19 passed in 1.14 seconds ===========================
Coverage.py warning: No data was collected. (no-data-collected)
/nix/store/a9x5sjarx4xfb4qki818iipb55kxrbwh-python2.7-python-slackclient-1.2.1
/nix/store/ab5pva8zc90dmnpqjf3b5kmc5d9bp34f-python3.6-python-slackclient-1.2.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.slackclient, python3Packages.slackclient

Partial log (click to expand)

tests/test_channel.py .....                                              [ 26%]
tests/test_slackclient.py ......                                         [ 57%]
tests/test_slackrequest.py ........                                      [100%]



========================== 19 passed in 1.14 seconds ===========================
Coverage.py warning: No data was collected. (no-data-collected)
/nix/store/9irrsj4nfggcprn5ylz8lyr8x3r5d5id-python2.7-python-slackclient-1.2.1
/nix/store/yg6r2010c8mk701myk7r4073dsmjpcy5-python3.6-python-slackclient-1.2.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.slackclient, python3Packages.slackclient

Partial log (click to expand)

tests/test_channel.py .....                                              [ 26%]
tests/test_slackclient.py ......                                         [ 57%]
tests/test_slackrequest.py ........                                      [100%]



========================== 19 passed in 0.30 seconds ===========================
Coverage.py warning: No data was collected. (no-data-collected)
/nix/store/54d1lmmb2cm8q5blk6z5bdlx8056qy67-python2.7-python-slackclient-1.2.1
/nix/store/hwpzy7gwg16jr9jcsh9askjc9i8lpr4q-python3.6-python-slackclient-1.2.1

Mic92
Mic92 reviewed Jul 29, 2018
View reviewed changes
pkgs/development/python-modules/slackclient/default.nix Outdated
checkInputs = [ pytest codecov coverage mock pytestcov pytest-mock responses flake8 ];
# test_server.py fails because it needs connection (I think);
checkPhase = ''
flake8 slackclient
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the package build should break because of coding style issue. This is more useful if applied upstream as it might break our builds if we update flake8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 Yeah you are right, What you suggest then as a temporary fix/workaround ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just remove this line from checkPhase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Thanks for the help

@Mic92 Mic92 merged commit d9cea0e into NixOS:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PsyanticY @FRidh @GrahamcOfBorg @Mic92