Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: 10.6.0 -> 10.7.0 #44153

Merged
merged 1 commit into from Aug 3, 2018
Merged

nodejs: 10.6.0 -> 10.7.0 #44153

merged 1 commit into from Aug 3, 2018

Conversation

Kaali
Copy link

@Kaali Kaali commented Jul 27, 2018

Motivation for this change

nodejs 10_x stable has updated in upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Kaali
Copy link
Author

Kaali commented Jul 29, 2018

Mention maintainers as per review guidelines: @cillianderoiste @gilligan @cko

@ivan
Copy link
Member

ivan commented Jul 29, 2018

The build succeeds here on NixOS as well, and the outputs work. (applied onto e46e7f4)

@adisbladis
Copy link
Member

@GrahamcOfBorg build nodejs-10_x

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nodejs-10_x

Partial log (click to expand)

└───────────────────────────────────────────────────────────────┘
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qfl494qpdqmlifzzy42afrrggniyp2wm-nodejs-10.7.0
shrinking /nix/store/qfl494qpdqmlifzzy42afrrggniyp2wm-nodejs-10.7.0/bin/node
gzipping man pages under /nix/store/qfl494qpdqmlifzzy42afrrggniyp2wm-nodejs-10.7.0/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qfl494qpdqmlifzzy42afrrggniyp2wm-nodejs-10.7.0/lib  /nix/store/qfl494qpdqmlifzzy42afrrggniyp2wm-nodejs-10.7.0/bin
patching script interpreter paths in /nix/store/qfl494qpdqmlifzzy42afrrggniyp2wm-nodejs-10.7.0
checking for references to /build in /nix/store/qfl494qpdqmlifzzy42afrrggniyp2wm-nodejs-10.7.0...
/nix/store/qfl494qpdqmlifzzy42afrrggniyp2wm-nodejs-10.7.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nodejs-10_x

Partial log (click to expand)

│              Try running with sudo or get access              │
│             to the local update config store via              │
│ sudo chown -R $USER:$(id -gn $USER) /homeless-shelter/.config │
└───────────────────────────────────────────────────────────────┘
post-installation fixup
gzipping man pages under /nix/store/32dkgyj0k8x2p665f44x1xwi2fdh69jr-nodejs-10.7.0/share/man/
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/32dkgyj0k8x2p665f44x1xwi2fdh69jr-nodejs-10.7.0/lib  /nix/store/32dkgyj0k8x2p665f44x1xwi2fdh69jr-nodejs-10.7.0/bin
patching script interpreter paths in /nix/store/32dkgyj0k8x2p665f44x1xwi2fdh69jr-nodejs-10.7.0
/nix/store/32dkgyj0k8x2p665f44x1xwi2fdh69jr-nodejs-10.7.0

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: nodejs-10_x

Partial log (click to expand)

  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.15"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.7.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.7.0/out/Release/.deps//build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/debug/liveedit.o.d.raw   -c -o /build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/debug/liveedit.o ../deps/v8/src/debug/liveedit.cc
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.15"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.7.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.7.0/out/Release/.deps//build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/deoptimize-reason.o.d.raw   -c -o /build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/deoptimize-reason.o ../deps/v8/src/deoptimize-reason.cc
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.15"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.7.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.7.0/out/Release/.deps//build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/deoptimizer.o.d.raw   -c -o /build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/deoptimizer.o ../deps/v8/src/deoptimizer.cc
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.15"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.7.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.7.0/out/Release/.deps//build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/disassembler.o.d.raw   -c -o /build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/disassembler.o ../deps/v8/src/disassembler.cc
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.15"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.7.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.7.0/out/Release/.deps//build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/diy-fp.o.d.raw   -c -o /build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/diy-fp.o ../deps/v8/src/diy-fp.cc
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.15"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.7.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.7.0/out/Release/.deps//build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/dtoa.o.d.raw   -c -o /build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/dtoa.o ../deps/v8/src/dtoa.cc
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.15"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.7.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.7.0/out/Release/.deps//build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/eh-frame.o.d.raw   -c -o /build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/eh-frame.o ../deps/v8/src/eh-frame.cc
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.15"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.7.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.7.0/out/Release/.deps//build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/elements-kind.o.d.raw   -c -o /build/node-v10.7.0/out/Release/obj.target/v8_base/deps/v8/src/elements-kind.o ../deps/v8/src/elements-kind.cc
building of '/nix/store/3smbml89ij4srhy86xrw1pbm7fd52hx6-nodejs-10.7.0.drv' timed out after 3600 seconds
error: build of '/nix/store/3smbml89ij4srhy86xrw1pbm7fd52hx6-nodejs-10.7.0.drv' failed

@adisbladis
Copy link
Member

Tested manually on x86_64-linux. Thanks @Kaali!

@adisbladis adisbladis merged commit 8b6e575 into NixOS:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kaali @ivan @adisbladis @GrahamcOfBorg