Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nginx modules #44161

Merged
merged 4 commits into from Jul 30, 2018
Merged

Nginx modules #44161

merged 4 commits into from Jul 30, 2018

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jul 27, 2018 •
edited

Motivation for this change

Add nginx modules - vts, push-stream, upstream-tarantool

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jul 29, 2018

Nitpick on the commit title:

  • nginx-mudules: vts: init at v0.1.18 -> nginxModules.vts: init at v0.1.18
  • nginx-mudules: push-stream: init at v0.5.4 -> nginxModules.push-stream: init at v0.5.4
  • nginx-mudules: upstream-tarantool: init at v2.7 -> nginxModules.upstream-tarantool: init at v2.7

@Izorkin
Copy link
Contributor Author

Izorkin commented Jul 29, 2018

Fix commit.

@Mic92 Mic92 merged commit 9cfc9de into NixOS:master Jul 30, 2018
@Izorkin Izorkin deleted the nginx-modules branch July 30, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @Mic92 @GrahamcOfBorg