search: include version for matches too! #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand what this does. What is the output after this change? |
|
Currently if a search matches the attribute name, the version portion of the attribute name is not shown. This is most easily seen by looking at the output of "nix search". The portion in parenthesis contains just the name not the version as well--indeed the version will only be present for derivations that |
|
After this change the portion in parens contains the full name--including version-- which is what is currently shown when for entries that don't match via attribute name (try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the matching isn't done against fullName
the match suffix doesn't include version
for "good" derivations that are parsed properly.
Searching without a match string always shows
the full name, with this the full name
is always shown.
Really helps when you just wanna see what version
is available currently! :)