fzf: fix invalid symlink on vim-plugins #44154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fzf vim plugin wasn't working because it was making a symlink to a directory with the full source code. This directory isn't present anymore since the commit e95f17e wich removes it because it isn't so useful for the go packages. I fixed it by manually copying the plugin/ directory into the out derivation, which is the only part of the source that contains the vim plugin.
cript0nauta
added a commit
to cript0nauta/dotfiles
that referenced
this pull request
Aug 1, 2018
Use a nixpkgs versions that includes my fix to fzf NixOS/nixpkgs#44154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The fzf vim plugin wasn't working because it was making a symlink to a
directory with the full source code of fzf. This directory isn't present
anymore since the commit e95f17e wich
removes it because it isn't so useful for the go packages.
Things done
I fixed it by manually copying the plugin/ directory into the out
derivation, which is the only part of the source that contains the vim
plugin.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)