Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc8: 8.1 -> 8.2 #44151

Merged
merged 1 commit into from Jul 28, 2018
Merged

gcc8: 8.1 -> 8.2 #44151

merged 1 commit into from Jul 28, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 27, 2018

https://gcc.gnu.org/gcc-8/changes.html

Motivation for this change

Second in 8 series, lots of fixes!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Don't think "WIP" is quite right, but definitely could use some testing. I don't believe this has any in-tree users (other than the cc-tests), but it'd be good to test on major platforms/configurations, like we did for 8.1.

cc #39866

@dtzWill
Copy link
Member Author

dtzWill commented Jul 27, 2018

@build gcc8 tests.cc-wrapper-gcc8

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: gcc8

Partial log (click to expand)

make[3]: *** [../../../gcc-8.2.0/libgcc/shared-object.mk:36: avx_savms64_s.o] Error 1
make[3]: Leaving directory '/private/tmp/nix-build-gcc-8.2.0.drv-0/build/x86_64-apple-darwin/libgcc'
make[2]: *** [Makefile:16352: all-stage1-target-libgcc] Error 2
make[2]: Leaving directory '/private/tmp/nix-build-gcc-8.2.0.drv-0/build'
make[1]: *** [Makefile:20872: stage1-bubble] Error 2
make[1]: Leaving directory '/private/tmp/nix-build-gcc-8.2.0.drv-0/build'
make: *** [Makefile:21177: bootstrap] Error 2
builder for '/nix/store/7xyb0dchia8qc5x5i6hwvdvw25r4zs0r-gcc-8.2.0.drv' failed with exit code 2
cannot build derivation '/nix/store/9y8vlbn5ic0clk0a51ib0cn0g6dhggww-gcc-wrapper-8.2.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/9y8vlbn5ic0clk0a51ib0cn0g6dhggww-gcc-wrapper-8.2.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: gcc8

Partial log (click to expand)

  insn-conditions.md > tmp-emit.c
/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/bash ../../gcc-8.2.0/gcc/../move-if-change tmp-opinit.h insn-opinit.h
/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/bash ../../gcc-8.2.0/gcc/../move-if-change tmp-opinit.c insn-opinit.c
echo timestamp > s-opinit
build/genextract ../../gcc-8.2.0/gcc/common.md ../../gcc-8.2.0/gcc/config/i386/i386.md \
  insn-conditions.md > tmp-extract.c
/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/bash ../../gcc-8.2.0/gcc/../move-if-change tmp-emit.c insn-emit.c
building of '/nix/store/8zdi08pwdvph4ymjshd36pzr7bx9n7k5-gcc-8.2.0.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/x40s4rgi6l1y6csp118rcxmm4scym6n5-gcc-wrapper-8.2.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/x40s4rgi6l1y6csp118rcxmm4scym6n5-gcc-wrapper-8.2.0.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gcc8

Partial log (click to expand)

patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6b3cq57khn5w08i0rjgw9981dshkhl88-gcc-wrapper-8.2.0
patching script interpreter paths in /nix/store/6b3cq57khn5w08i0rjgw9981dshkhl88-gcc-wrapper-8.2.0
checking for references to /build in /nix/store/6b3cq57khn5w08i0rjgw9981dshkhl88-gcc-wrapper-8.2.0...
/nix/store/6b3cq57khn5w08i0rjgw9981dshkhl88-gcc-wrapper-8.2.0

@dtzWill dtzWill merged commit 018c665 into NixOS:master Jul 28, 2018
@dtzWill dtzWill deleted the update/gcc-8.2 branch July 28, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg