pythonPackages.sortedcontainers: 1.5.7 -> 2.0.4 #44653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will need to add myself as a maintainer before merging |
costrouc
force-pushed
the
costrouc/sortedcontainers
branch
from
cb0710d
to
c411cfc
Compare
|
Requires myself to be added to maintainers (pull request #44655) list before this pull request |
9 tasks
|
@GrahamcOfBorg eval |
dotlambda
requested changes
Aug 8, 2018
|
|
||
| meta = { | ||
| description = "Python Sorted Container Types: SortedList, SortedDict, and SortedSet"; | ||
| homepage = "http://www.grantjenks.com/docs/sortedcontainers/"; |
|
|
||
| # tries to run tests for all python versions and uses virtualenv weirdly | ||
| doCheck = false; | ||
| #buildInputs = with self; [ tox nose ]; |
There was a problem hiding this comment.
That's not true.
checkPhase = ''
py.test
''
should suffice.
There was a problem hiding this comment.
Those lines were left over from the original. The Pypi tarball does not come with tests. So I have now set doCheck = false; with appropriate comment.
Moving sortedcontianers from top-level -> python-modules and updating to newest sortedcontianers release.
costrouc
force-pushed
the
costrouc/sortedcontainers
branch
from
c411cfc
to
5d485b3
Compare
|
@GrahamcOfBorg build python2.pkgs.sortedcontainers python3.pkgs.sortedcontainers |
|
Success on x86_64-linux (full log) Attempted: python2.pkgs.sortedcontainers, python3.pkgs.sortedcontainers Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python2.pkgs.sortedcontainers, python3.pkgs.sortedcontainers Partial log (click to expand)
|
|
@GrahamcOfBorg build python2.pkgs.sortedcontainers python3.pkgs.sortedcontainers |
|
Requested changes have been made and commit and messages have been corrected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Moving sortedcontianers from top-level -> python-modules and updating
to newest sortedcontianers release.
Things done
pythonPackages.sortedcontainers: 1.5.7 -> 2.0.4
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)