Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.singledispatch: move expression #44654

Merged
merged 1 commit into from Aug 8, 2018
Merged

pythonPackages.singledispatch: move expression #44654

merged 1 commit into from Aug 8, 2018

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Aug 8, 2018

Motivation for this change

no change in version just moving singledispatch to python-modules

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner August 8, 2018 01:46
@costrouc
Copy link
Member Author

costrouc commented Aug 8, 2018

Need to add myself as maintainer before merging

@costrouc
Copy link
Member Author

costrouc commented Aug 8, 2018

Requires myself to be added to maintainers (pull request #44655) list before this pull request

@costrouc costrouc mentioned this pull request Aug 8, 2018
Closed
9 tasks
@xeji
Copy link
Contributor

xeji commented Aug 8, 2018

@GrahamcOfBorg eval

@dotlambda dotlambda changed the title pythonPackages.singledispatch: 3.4.0.3 pythonPackages.singledispatch: init at 3.4.0.3 Aug 8, 2018
dotlambda
dotlambda requested changes Aug 8, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits and correct the commit message

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.singledispatch python3.pkgs.singledispatch

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.singledispatch, python3.pkgs.singledispatch

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'singledispatch.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/dq6v1vjjg1i07q7846yz33hv84skb3sf-python2.7-singledispatch-3.4.0.3
/nix/store/7zh5r5b3jb0i6ps7v011q6ycdf27b404-python3.6-singledispatch-3.4.0.3

@dotlambda
Copy link
Member

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase or set doCheck = false and add a comment on why you're doing that.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.singledispatch, python3.pkgs.singledispatch

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'singledispatch.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.001s

OK
/nix/store/54nmk0nlbm15vqbrijj3fzkwiplyfk59-python2.7-singledispatch-3.4.0.3
/nix/store/ygl29bxccx0m4svxhnl05bdbfdaws4pg-python3.6-singledispatch-3.4.0.3

@costrouc
pythonPackages.singledispatch: 3.4.0.3
05cd51a 
no change in version just moving singledispatch to python-modules.

 - no tests singe using pypi tarball
@costrouc costrouc force-pushed the costrouc/singledispatch-update branch from 0d1386b to 05cd51a Compare August 8, 2018 12:31
@costrouc
Copy link
Member Author

costrouc commented Aug 8, 2018

@GrahamcOfBorg build python2.pkgs.singledispatch python3.pkgs.singledispatch

@costrouc
Copy link
Member Author

costrouc commented Aug 8, 2018

Commits have been squashed and appropriate commit message is given

@dotlambda dotlambda changed the title pythonPackages.singledispatch: init at 3.4.0.3 pythonPackages.singledispatch: move expression Aug 8, 2018
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.singledispatch python3.pkgs.singledispatch

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.singledispatch, python3.pkgs.singledispatch

Partial log (click to expand)

Successfully installed singledispatch-3.4.0.3
/build/singledispatch-3.4.0.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3vxv4mb17q5nnax8klh378smv6agwq0i-python3.6-singledispatch-3.4.0.3
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3vxv4mb17q5nnax8klh378smv6agwq0i-python3.6-singledispatch-3.4.0.3/lib
patching script interpreter paths in /nix/store/3vxv4mb17q5nnax8klh378smv6agwq0i-python3.6-singledispatch-3.4.0.3
checking for references to /build in /nix/store/3vxv4mb17q5nnax8klh378smv6agwq0i-python3.6-singledispatch-3.4.0.3...
/nix/store/dqqz3m0f63g2wk7lxc939j5cbz9hn5kb-python2.7-singledispatch-3.4.0.3
/nix/store/3vxv4mb17q5nnax8klh378smv6agwq0i-python3.6-singledispatch-3.4.0.3

@dotlambda dotlambda merged commit 74f0282 into NixOS:master Aug 8, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.singledispatch, python3.pkgs.singledispatch

Partial log (click to expand)

Successfully installed singledispatch-3.4.0.3
/build/singledispatch-3.4.0.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dhimr2j23rn6nnpbv0y9zr81718xy00w-python3.6-singledispatch-3.4.0.3
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dhimr2j23rn6nnpbv0y9zr81718xy00w-python3.6-singledispatch-3.4.0.3/lib
patching script interpreter paths in /nix/store/dhimr2j23rn6nnpbv0y9zr81718xy00w-python3.6-singledispatch-3.4.0.3
checking for references to /build in /nix/store/dhimr2j23rn6nnpbv0y9zr81718xy00w-python3.6-singledispatch-3.4.0.3...
/nix/store/djh59gy2bw5lsfl79nclnbhznklf8cdk-python2.7-singledispatch-3.4.0.3
/nix/store/dhimr2j23rn6nnpbv0y9zr81718xy00w-python3.6-singledispatch-3.4.0.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.singledispatch, python3.pkgs.singledispatch

Partial log (click to expand)

Requirement already satisfied: six in /nix/store/rz8dsbls2k99wb5b6mdg2vsjfwv34inw-python3.6-six-1.11.0/lib/python3.6/site-packages (from singledispatch==3.4.0.3) (1.11.0)
Installing collected packages: singledispatch
Successfully installed singledispatch-3.4.0.3
/private/tmp/nix-build-python3.6-singledispatch-3.4.0.3.drv-0/singledispatch-3.4.0.3
post-installation fixup
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/dr2s4j7wy3y13x66bpc4phlgkc5izg7q-python3.6-singledispatch-3.4.0.3/lib
patching script interpreter paths in /nix/store/dr2s4j7wy3y13x66bpc4phlgkc5izg7q-python3.6-singledispatch-3.4.0.3
/nix/store/l6icnmigwk1bwwmc5vrzya5r6cjrazmw-python2.7-singledispatch-3.4.0.3
/nix/store/dr2s4j7wy3y13x66bpc4phlgkc5izg7q-python3.6-singledispatch-3.4.0.3

@costrouc costrouc deleted the costrouc/singledispatch-update branch August 8, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @xeji @dotlambda @GrahamcOfBorg