Feature/brother ql #44646
Closed
Feature/brother ql #44646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
requested changes
Aug 7, 2018
| propagatedBuildInputs = [ future packbits pillow pyusb ]; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Python package for the raster language protocol of the Brother QL series label printers (QL-500, QL-550, QL-570, QL-700, QL-710W, QL-720NW, QL-800, QL-820NWB, QL-1050 and more)"; |
| description = "Python package for the raster language protocol of the Brother QL series label printers (QL-500, QL-550, QL-570, QL-700, QL-710W, QL-720NW, QL-800, QL-820NWB, QL-1050 and more)"; | ||
| homepage = https://github.com/pklaus/brother_ql; | ||
| license = licenses.gpl3; | ||
| maintainers = with maintainers; [ ]; |
| description = "PackBits encoder/decoder for Python"; | ||
| homepage = https://github.com/psd-tools/packbits; | ||
| license = [ licenses.bsd2 ]; | ||
| maintainers = with maintainers; [ ]; |
| @@ -232,6 +232,8 @@ in { | |||
|
|
|||
| breathe = callPackage ../development/python-modules/breathe { }; | |||
|
|
|||
| brother_ql = callPackage ../development/python-modules/brother_ql { }; | |||
There was a problem hiding this comment.
Is brother_ql really a Python module, seems more like a CLI tool only. In that case, it doesn't belong in pythonPackages and should use buildPythonApplication.
There was a problem hiding this comment.
It is a library and application. There is a brother_ql_web program that uses brother_ql as a dependency. It has however also some scripts to create labels.
There was a problem hiding this comment.
Okay, then it belongs into pythonPackages.
poelzi
force-pushed
the
feature/brother_ql
branch
from
9f5167d
to
36f7740
Compare
dotlambda
requested changes
Aug 9, 2018
| meta = with stdenv.lib; { | ||
| description = ''Python package for the raster language protocol of the Brother QL series\ | ||
| label printers (QL-500, QL-550, QL-570, QL-700, QL-710W, QL-720NW, QL-800,\ | ||
| QL-820NWB, QL-1050 and more)''; |
There was a problem hiding this comment.
This must be a short one-liner: https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes
|
Any updates on this pull request, please? |
|
@poelzi Are you still interested in moving this forward? |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Allows to print label with the Brother QL printer line. Tested and works with a QL-800 printer on Linux.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)