Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luksroot: Add missing quote #44639

Merged
merged 1 commit into from Aug 7, 2018
Merged

luksroot: Add missing quote #44639

merged 1 commit into from Aug 7, 2018

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Aug 7, 2018 •
edited

Motivation for this change

Getting -e not found for cryptsetup on boot, this seems to fix it though? Just adds a missing quote (#41425) and aligns the lines.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 7, 2018

cc @dasJ

@xeji xeji merged commit aea2d82 into NixOS:master Aug 7, 2018
@samueldr samueldr mentioned this pull request Aug 7, 2018
Merged
8 tasks
@eadwu eadwu deleted the luksroot/fix-syntax branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @xeji @GrahamcOfBorg