Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add /share/sddm/themes to environment.pathsToLink #44649

Merged
merged 1 commit into from Aug 9, 2018
Merged

add /share/sddm/themes to environment.pathsToLink #44649

merged 1 commit into from Aug 9, 2018

Conversation

dmanam
Copy link
Contributor

@dmanam dmanam commented Aug 8, 2018

Without this, there are no SDDM themes available in the directory configured in sddm.conf.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Please format your commit message according to the contribution guidelines (also linked in the issue template) by adding the nixos/sddm: prefix.

@dmanam
nixos/sddm: add /share/sddm/themes to environment.pathsToLink
414e6de 
Without this, there are no SDDM themes available in the directory configured in `sddm.conf`.
@dmanam
Copy link
Contributor Author

dmanam commented Aug 9, 2018

Sorry, fixed now.

@infinisil
Copy link
Member

Awesome, thanks!

@infinisil infinisil merged commit c08244f into NixOS:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dmanam @infinisil @matthewbauer @GrahamcOfBorg @Janik-Haag