[WIP] radare2: 2.7.0 -> 2.8.0, radare2-cutter: 1.6 -> 1.7, refactor #44650

dtzWill · 2018-08-08T00:57:04Z

GrahamcOfBorg · 2018-08-08T01:10:48Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: radare2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-08-08T01:14:01Z

Success on aarch64-linux (full log)

Attempted: radare2

Partial log (click to expand)

shrinking /nix/store/6bz150515jy2vivgw6syfwvxpa01b9lx-radare2-2.8.0/lib/libr_crypto.so.2.8.0
shrinking /nix/store/6bz150515jy2vivgw6syfwvxpa01b9lx-radare2-2.8.0/lib/libr_hash.so.2.8.0
shrinking /nix/store/6bz150515jy2vivgw6syfwvxpa01b9lx-radare2-2.8.0/lib/libr_util.so.2.8.0
gzipping man pages under /nix/store/6bz150515jy2vivgw6syfwvxpa01b9lx-radare2-2.8.0/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6bz150515jy2vivgw6syfwvxpa01b9lx-radare2-2.8.0/lib  /nix/store/6bz150515jy2vivgw6syfwvxpa01b9lx-radare2-2.8.0/bin
patching script interpreter paths in /nix/store/6bz150515jy2vivgw6syfwvxpa01b9lx-radare2-2.8.0
/nix/store/6bz150515jy2vivgw6syfwvxpa01b9lx-radare2-2.8.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/6vqgi9d49smsbr2qxra52yhipg0yxf9f-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/6bz150515jy2vivgw6syfwvxpa01b9lx-radare2-2.8.0...
/nix/store/6bz150515jy2vivgw6syfwvxpa01b9lx-radare2-2.8.0

GrahamcOfBorg · 2018-08-08T01:26:47Z

Success on x86_64-linux (full log)

Attempted: radare2

Partial log (click to expand)

shrinking /nix/store/ixy8knlak75s0fb79clwix5z8b2yln2b-radare2-2.8.0/bin/rasm2
shrinking /nix/store/ixy8knlak75s0fb79clwix5z8b2yln2b-radare2-2.8.0/bin/r2agent
shrinking /nix/store/ixy8knlak75s0fb79clwix5z8b2yln2b-radare2-2.8.0/bin/rahash2
gzipping man pages under /nix/store/ixy8knlak75s0fb79clwix5z8b2yln2b-radare2-2.8.0/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ixy8knlak75s0fb79clwix5z8b2yln2b-radare2-2.8.0/lib  /nix/store/ixy8knlak75s0fb79clwix5z8b2yln2b-radare2-2.8.0/bin
patching script interpreter paths in /nix/store/ixy8knlak75s0fb79clwix5z8b2yln2b-radare2-2.8.0
/nix/store/ixy8knlak75s0fb79clwix5z8b2yln2b-radare2-2.8.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/ixy8knlak75s0fb79clwix5z8b2yln2b-radare2-2.8.0...
/nix/store/ixy8knlak75s0fb79clwix5z8b2yln2b-radare2-2.8.0

Mic92 · 2018-08-08T08:07:44Z

Now we have a problem that we check CS_TIP, which breaks radare2-for-cutter:

unpacking source archive /nix/store/7jx11qyfkdswvwhqnz20v6m703rk94sg-source
source root is source
patching sources
CS_TIP mismatch
builder for '/nix/store/99phyhxdssng0i5lb5vwmklk05nph36q-radare2-for-cutter-1.6.drv' failed with exit code 1

It is probably the best to move radare2-cutter to the radare2 directory and let it have its own pinning.

Regarding update.py:

if len(sys.argv) > 2:
  expression_file = sys.argv[1]
else:
  expression_file = "default.nix"

GrahamcOfBorg · 2018-08-08T12:02:12Z

Failure on aarch64-linux (full log)

Attempted: radare2, radare2-cutter

Partial log (click to expand)

cannot build derivation '/nix/store/p7xi7nmizxak273gc03qlc7822f957aa-qtsvg-5.11.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/hyw3awsisl0v50pr84f5hpy2f5dldzk9-qtxmlpatterns-5.11.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/kvk249wsmallnsxxxmc4id9z47lrjmi1-qtdeclarative-5.11.1.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/crgiwiaka5gslhdvjjc3f0ix1h4ngr9a-qtmultimedia-5.11.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/p7dx0sjdwf7fzvf63kbv72djzgw6fkha-qtquickcontrols-5.11.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/81l0xn5xj7cln2sbqalx5a9711449la9-qtwebchannel-5.11.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/c7fqkdw7lykxvshzm8871hjv9kbiw0qj-qtlocation-5.11.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/cwmkbvbagd1dy9v4bfsiv7lg851qpg1q-qtwebengine-5.11.1.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/rgjv46vgwk8hj7fcawhlrmzqybbnki0v-radare2-cutter-1.6.drv': 4 dependencies couldn't be built
error: build of '/nix/store/rgjv46vgwk8hj7fcawhlrmzqybbnki0v-radare2-cutter-1.6.drv' failed

GrahamcOfBorg · 2018-08-08T12:03:05Z

Failure on x86_64-darwin (full log)

Attempted: radare2-cutter

The following builds were skipped because they don't evaluate on x86_64-darwin: radare2

Partial log (click to expand)

/nix/store/9nq2zkj8a44vqawv5xp8hjk4ll55xij3-radare2-for-cutter-1.6/lib/libr_fs.2.8.0-git.dylib: fixing dylib
/nix/store/9nq2zkj8a44vqawv5xp8hjk4ll55xij3-radare2-for-cutter-1.6/lib/libr_core.2.8.0-git.dylib: fixing dylib
/nix/store/9nq2zkj8a44vqawv5xp8hjk4ll55xij3-radare2-for-cutter-1.6/lib/libr_magic.2.8.0-git.dylib: fixing dylib
/nix/store/9nq2zkj8a44vqawv5xp8hjk4ll55xij3-radare2-for-cutter-1.6/lib/libr_parse.2.8.0-git.dylib: fixing dylib
/nix/store/9nq2zkj8a44vqawv5xp8hjk4ll55xij3-radare2-for-cutter-1.6/lib/libr_asm.2.8.0-git.dylib: fixing dylib
/nix/store/9nq2zkj8a44vqawv5xp8hjk4ll55xij3-radare2-for-cutter-1.6/lib/libr_debug.2.8.0-git.dylib: fixing dylib
/nix/store/9nq2zkj8a44vqawv5xp8hjk4ll55xij3-radare2-for-cutter-1.6/lib/libr_util.2.8.0-git.dylib: fixing dylib
/nix/store/9nq2zkj8a44vqawv5xp8hjk4ll55xij3-radare2-for-cutter-1.6/lib/libr_bp.2.8.0-git.dylib: fixing dylib
cannot build derivation '/nix/store/hncvk2b3xb8y22xliz6bzjvlwhjdg8rj-radare2-cutter-1.6.drv': 1 dependencies couldn't be built
error: build of '/nix/store/hncvk2b3xb8y22xliz6bzjvlwhjdg8rj-radare2-cutter-1.6.drv' failed

dtzWill · 2018-08-08T12:06:08Z

It is probably the best to move radare2-cutter to the radare2 directory and let it have its own pinning.

hmm okay, agreed. Sorry didn't see this earlier :).

GrahamcOfBorg · 2018-08-08T12:50:54Z

Failure on x86_64-linux (full log)

Attempted: radare2, radare2-cutter

Partial log (click to expand)

shrinking /nix/store/vn2bzyhjgz1fbnk2afc5993msc7s2rvg-radare2-for-cutter-1.6/bin/rabin2
shrinking /nix/store/vn2bzyhjgz1fbnk2afc5993msc7s2rvg-radare2-for-cutter-1.6/bin/rarun2
gzipping man pages under /nix/store/vn2bzyhjgz1fbnk2afc5993msc7s2rvg-radare2-for-cutter-1.6/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vn2bzyhjgz1fbnk2afc5993msc7s2rvg-radare2-for-cutter-1.6/lib  /nix/store/vn2bzyhjgz1fbnk2afc5993msc7s2rvg-radare2-for-cutter-1.6/bin
patching script interpreter paths in /nix/store/vn2bzyhjgz1fbnk2afc5993msc7s2rvg-radare2-for-cutter-1.6
/nix/store/vn2bzyhjgz1fbnk2afc5993msc7s2rvg-radare2-for-cutter-1.6/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/vn2bzyhjgz1fbnk2afc5993msc7s2rvg-radare2-for-cutter-1.6...
cannot build derivation '/nix/store/9wlc2j1bm04ny15hxlnmh9z2k4ggd392-radare2-cutter-1.6.drv': 1 dependencies couldn't be built
error: build of '/nix/store/9wlc2j1bm04ny15hxlnmh9z2k4ggd392-radare2-cutter-1.6.drv' failed

dtzWill · 2018-08-21T23:25:26Z

Alright well this at least works and hopefully get things mostly to what you had in mind. The update script needs fixing to work with radare2-cutter as well as radare2 (same info, new location). Help appreciated but no rush/pressure :).

GrahamcOfBorg · 2018-08-21T23:36:05Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: radare2, radare2-cutter

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-08-21T23:40:05Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: radare2, radare2-cutter

Partial log (click to expand)

shrinking /nix/store/ccjb5qqdia84zm8ylmf1mka1r96c8lr6-radare2-2.8.0/bin/radare2
shrinking /nix/store/ccjb5qqdia84zm8ylmf1mka1r96c8lr6-radare2-2.8.0/bin/rasm2
shrinking /nix/store/ccjb5qqdia84zm8ylmf1mka1r96c8lr6-radare2-2.8.0/bin/rahash2
gzipping man pages under /nix/store/ccjb5qqdia84zm8ylmf1mka1r96c8lr6-radare2-2.8.0/share/man/
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
stripping (with command /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip and flags -S) in /nix/store/ccjb5qqdia84zm8ylmf1mka1r96c8lr6-radare2-2.8.0/lib  /nix/store/ccjb5qqdia84zm8ylmf1mka1r96c8lr6-radare2-2.8.0/bin
patching script interpreter paths in /nix/store/ccjb5qqdia84zm8ylmf1mka1r96c8lr6-radare2-2.8.0
/nix/store/ccjb5qqdia84zm8ylmf1mka1r96c8lr6-radare2-2.8.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/ccjb5qqdia84zm8ylmf1mka1r96c8lr6-radare2-2.8.0...
error: build of '/nix/store/zq9mx27725jpkk0kzrsrawn7xvrri37y-radare2-cutter-1.7.drv' failed

GrahamcOfBorg · 2018-08-22T00:36:21Z

Timed out, unknown build status on aarch64-linux (full log)

Attempted: radare2, radare2-cutter

Partial log (click to expand)

[6930/16620] CXX obj/third_party/webrtc/modules/pacing/pacing/alr_detector.o
[6931/16620] CXX obj/third_party/webrtc/pc/peerconnection/sdputils.o
[6932/16620] CXX obj/third_party/webrtc/rtc_base/rtc_base_approved_generic/base64.o
[6933/16620] CXX obj/third_party/webrtc/rtc_base/rtc_base_approved_generic/bitbuffer.o
[6934/16620] CXX obj/third_party/webrtc/p2p/rtc_p2p/turnportfactory.o
[6935/16620] CXX obj/third_party/webrtc/pc/rtc_pc_base/bundlefilter.o
[6936/16620] CXX obj/third_party/webrtc/rtc_base/rtc_base_approved_generic/location.o
building of '/nix/store/if0fi61ifg04sqkcgsmvm3p74423pk8r-qtwebengine-5.11.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/az5x55prv2g8bh3l20caw7kkmvy0v1r9-radare2-cutter-1.7.drv': 2 dependencies couldn't be built
error: build of '/nix/store/az5x55prv2g8bh3l20caw7kkmvy0v1r9-radare2-cutter-1.7.drv' failed

Mic92 · 2018-08-22T10:47:12Z

pkgs/development/tools/analysis/radare2/default.nix

+    sha256 = "1ix42kipd1aayb494ajbxawzc1cwikm9fxk343d1kchxx4a30a1m";
+    cs_tip = "782ea67e17a391ca0d3faafdc365b335a1a8930a";
+    cs_sha256 = "1maww4ir78a193pm3f8lr2kdkizi7rywn68ffa65ipyr7j4pl6i4";
+  };


Please test & merge

dtzWill · 2018-08-22T14:40:37Z

Looks great, thank you! \o/

Mic92 · 2018-08-23T09:25:25Z

pkgs/development/tools/analysis/radare2/update.py

+
+
+def get_r2_cutter_rev() -> str:
+    url = "https://api.github.com/repos/radareorg/cutter/contents/"


This should be the current version of cutter not the latest. I probably need to fix this in future.

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Aug 8, 2018

dtzWill requested a review from Mic92 August 8, 2018 01:33

dtzWill added 3 commits August 21, 2018 17:11

radare2: 2.7.0 -> 2.8.0

3c08c87

radare2-cutter: use newer r2, fix (latest rev used by cutter-git)

ec7af52

r2, r2-cutter: refactor and bump cutter to 1.7

2957313

dtzWill force-pushed the update/r2-2.8.0 branch from 2f7f0d1 to 2957313 Compare August 21, 2018 23:22

dtzWill changed the title ~~radare2: 2.7.0 -> 2.8.0~~ [WIP] radare2: 2.7.0 -> 2.8.0 Aug 21, 2018

dtzWill changed the title ~~[WIP] radare2: 2.7.0 -> 2.8.0~~ [WIP] radare2: 2.7.0 -> 2.8.0, radare2-cutter: 1.6 -> 1.7, refactor Aug 21, 2018

GrahamcOfBorg added the 8.has: package (new) label Aug 21, 2018

radare2: rework update script to include cutter's radare2 version

dc8cae2

Mic92 reviewed Aug 22, 2018

View reviewed changes

radare2: update.py should be formatted with black now

36d8beb

dtzWill merged commit cf68a14 into NixOS:master Aug 22, 2018

Mic92 reviewed Aug 23, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] radare2: 2.7.0 -> 2.8.0, radare2-cutter: 1.6 -> 1.7, refactor #44650

[WIP] radare2: 2.7.0 -> 2.8.0, radare2-cutter: 1.6 -> 1.7, refactor #44650

dtzWill commented Aug 8, 2018

GrahamcOfBorg commented Aug 8, 2018

GrahamcOfBorg commented Aug 8, 2018

GrahamcOfBorg commented Aug 8, 2018

Mic92 commented Aug 8, 2018 •

edited

GrahamcOfBorg commented Aug 8, 2018

GrahamcOfBorg commented Aug 8, 2018

dtzWill commented Aug 8, 2018

GrahamcOfBorg commented Aug 8, 2018

dtzWill commented Aug 21, 2018

GrahamcOfBorg commented Aug 21, 2018

GrahamcOfBorg commented Aug 21, 2018

GrahamcOfBorg commented Aug 22, 2018

Mic92 Aug 22, 2018 •

edited

dtzWill commented Aug 22, 2018

Mic92 Aug 23, 2018 •

edited



		def get_r2_cutter_rev() -> str:
		url = "https://api.github.com/repos/radareorg/cutter/contents/"

[WIP] radare2: 2.7.0 -> 2.8.0, radare2-cutter: 1.6 -> 1.7, refactor #44650

[WIP] radare2: 2.7.0 -> 2.8.0, radare2-cutter: 1.6 -> 1.7, refactor #44650

Conversation

dtzWill commented Aug 8, 2018

GrahamcOfBorg commented Aug 8, 2018

GrahamcOfBorg commented Aug 8, 2018

GrahamcOfBorg commented Aug 8, 2018

Mic92 commented Aug 8, 2018 • edited

GrahamcOfBorg commented Aug 8, 2018

GrahamcOfBorg commented Aug 8, 2018

dtzWill commented Aug 8, 2018

GrahamcOfBorg commented Aug 8, 2018

dtzWill commented Aug 21, 2018

GrahamcOfBorg commented Aug 21, 2018

GrahamcOfBorg commented Aug 21, 2018

GrahamcOfBorg commented Aug 22, 2018

Mic92 Aug 22, 2018 • edited

Choose a reason for hiding this comment

dtzWill commented Aug 22, 2018

Mic92 Aug 23, 2018 • edited

Choose a reason for hiding this comment

Mic92 commented Aug 8, 2018 •

edited

Mic92 Aug 22, 2018 •

edited

Mic92 Aug 23, 2018 •

edited