Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.jupyterlab 0.32.1 -> 0.33.7 #44638

Merged
merged 1 commit into from Aug 8, 2018
Merged

pythonPackages.jupyterlab 0.32.1 -> 0.33.7 #44638

merged 1 commit into from Aug 8, 2018

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Aug 7, 2018

Motivation for this change

previous jupyterlab 0.32.1 did not build due to requiring
jupyterlab_launcher version between (0.10.0 <-> 0.11.0) now
requires (0.11.2 <-> 0.12.0).

Things done

Updated: jupyterlab 0.32.1 -> 0.33.7

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner August 7, 2018 21:13
dotlambda
dotlambda requested changes Aug 7, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the commit message according to the guidelines, i.e. pythonPackages.jupyterlab: 0.32.1 -> 0.33.7

@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.jupyterlab

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.jupyterlab

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/k8bd7304p54yqcsfrf8hah03cg4ask62-python3.6-jupyterlab-0.33.7
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/k8bd7304p54yqcsfrf8hah03cg4ask62-python3.6-jupyterlab-0.33.7/lib  /nix/store/k8bd7304p54yqcsfrf8hah03cg4ask62-python3.6-jupyterlab-0.33.7/bin
patching script interpreter paths in /nix/store/k8bd7304p54yqcsfrf8hah03cg4ask62-python3.6-jupyterlab-0.33.7
checking for references to /build in /nix/store/k8bd7304p54yqcsfrf8hah03cg4ask62-python3.6-jupyterlab-0.33.7...
wrapping `/nix/store/k8bd7304p54yqcsfrf8hah03cg4ask62-python3.6-jupyterlab-0.33.7/bin/jlpm'...
wrapping `/nix/store/k8bd7304p54yqcsfrf8hah03cg4ask62-python3.6-jupyterlab-0.33.7/bin/jupyter-labhub'...
wrapping `/nix/store/k8bd7304p54yqcsfrf8hah03cg4ask62-python3.6-jupyterlab-0.33.7/bin/jupyter-lab'...
wrapping `/nix/store/k8bd7304p54yqcsfrf8hah03cg4ask62-python3.6-jupyterlab-0.33.7/bin/jupyter-labextension'...
/nix/store/k8bd7304p54yqcsfrf8hah03cg4ask62-python3.6-jupyterlab-0.33.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.jupyterlab

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/fc6qfq7g0cc22krwiykj3rbrgcv7cn1g-python3.6-jupyterlab-0.33.7
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fc6qfq7g0cc22krwiykj3rbrgcv7cn1g-python3.6-jupyterlab-0.33.7/lib  /nix/store/fc6qfq7g0cc22krwiykj3rbrgcv7cn1g-python3.6-jupyterlab-0.33.7/bin
patching script interpreter paths in /nix/store/fc6qfq7g0cc22krwiykj3rbrgcv7cn1g-python3.6-jupyterlab-0.33.7
checking for references to /build in /nix/store/fc6qfq7g0cc22krwiykj3rbrgcv7cn1g-python3.6-jupyterlab-0.33.7...
wrapping `/nix/store/fc6qfq7g0cc22krwiykj3rbrgcv7cn1g-python3.6-jupyterlab-0.33.7/bin/jupyter-labhub'...
wrapping `/nix/store/fc6qfq7g0cc22krwiykj3rbrgcv7cn1g-python3.6-jupyterlab-0.33.7/bin/jupyter-labextension'...
wrapping `/nix/store/fc6qfq7g0cc22krwiykj3rbrgcv7cn1g-python3.6-jupyterlab-0.33.7/bin/jupyter-lab'...
wrapping `/nix/store/fc6qfq7g0cc22krwiykj3rbrgcv7cn1g-python3.6-jupyterlab-0.33.7/bin/jlpm'...
/nix/store/fc6qfq7g0cc22krwiykj3rbrgcv7cn1g-python3.6-jupyterlab-0.33.7

@costrouc costrouc closed this Aug 8, 2018
@costrouc costrouc reopened this Aug 8, 2018
@costrouc
pythonPackages.jupyterlab: 0.32.1 -> 0.33.7
872413e 
previous jupyterlab 0.32.1 did not build due to requiring
jupyterlab_launcher version between (0.10.0 <-> 0.11.0) now
requires (0.11.2 <-> 0.12.0).
@costrouc
Copy link
Member Author

costrouc commented Aug 8, 2018

Requires myself to be added to maintainers (pull request #44655) list before this pull request

@costrouc costrouc changed the title Update jupyterlab 0.32.1 -> 0.33.7 pythonPackages.jupyterlab 0.32.1 -> 0.33.7 Aug 8, 2018
@xeji
Copy link
Contributor

xeji commented Aug 8, 2018

@GrahamcOfBorg eval

@dotlambda dotlambda merged commit 6ec399e into NixOS:master Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @dotlambda @GrahamcOfBorg @xeji