Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New dask-jobqueue 0.3.0, docrep 0.2.3. Updated distributed 1.15.1 -> 1.22.1 #44637

Closed
wants to merge 2 commits into from
Closed

New dask-jobqueue 0.3.0, docrep 0.2.3. Updated distributed 1.15.1 -> 1.22.1 #44637

wants to merge 2 commits into from

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Aug 7, 2018

motivation

Adding python package dask-jobqueue. dask-jobqueue has required
dependencies of new package docrep and updated version of
distributed.

The newest release of distributed has a change in
dependencies. msgpack-python (depreciated) -> msgpack and pyyaml
is a new dependency.

Things done

Added python package dask-distributed 0.3.0 and docrep 0.2.3.
Update python package distributed 1.15.1 -> 1.22.1

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc
New dask-jobqueue 0.3.0, docrep 0.2.3. Updated distributed 1.22.1
a4fb47b 
Adding python package `dask-jobqueue`. `dask-jobqueue` has required
dependencies of new package `docrep` and updated version of
`distributed`.

The newest release of `distributed` has a change in
dependencies. `msgpack-python` (depreciated) -> `msgpack` and `pyyaml`
is a new dependency.
@costrouc costrouc requested a review from FRidh as a code owner August 7, 2018 20:47
@costrouc costrouc changed the title New dask-jobqueue 0.3.0, docrep 0.2.3. Updated distributed 1.22.1 New dask-jobqueue 0.3.0, docrep 0.2.3. Updated distributed 1.15.1 -> 1.22.1 Aug 7, 2018
@dotlambda
Copy link
Member

Instead of removing meta.maintainers, why not add yourself to https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix? This should be done in an additional commit before the existing ones.
Also, please create a separate commit for each package and format the commit messages according to the guidelines, e.g. pythonPackages.docrep: init at 0.2.3.

dotlambda
dotlambda requested changes Aug 7, 2018
View reviewed changes
pkgs/development/python-modules/dask-jobqueue/default.nix
homepage = https://github.com/dask/dask-jobqueue;
license = lib.licenses.bsd3;
};
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final \n

pkgs/development/python-modules/docrep/default.nix
homepage = https://github.com/Chilipp/docrep;
license = lib.licenses.gpl2;
};
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final \n

pkgs/top-level/python-packages.nix
@@ -1979,17 +1983,17 @@ in {
distributed = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This expression needs to be moved to pkgs/development/python-modules/distributed/default.nix.

pkgs/top-level/python-packages.nix
@@ -1979,17 +1983,17 @@ in {
distributed = buildPythonPackage rec {

name = "distributed-${version}";
version = "1.15.1";
version = "1.22.1";

src = pkgs.fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchPypi

pkgs/top-level/python-packages.nix
@@ -1979,17 +1983,17 @@ in {
distributed = buildPythonPackage rec {

name = "distributed-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify pname = "distributed" instead.

dotlambda
dotlambda requested changes Aug 7, 2018
View reviewed changes
pkgs/top-level/python-packages.nix

src = pkgs.fetchurl {
url = "mirror://pypi/d/distributed/${name}.tar.gz";
sha256 = "037a07sdf2ch1d360nqwqz3b4ld8msydng7mw4i5s902v7xr05l6";
sha256 = "eefdd511912a001077bf1e00e2c3989dcfa853d68d14a8cd5b688c6175389e3a";
};

buildInputs = with self; [ pytest docutils ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkInputs

@costrouc
Copy link
Member Author

costrouc commented Aug 8, 2018

Closing and separating into separate pull requests.

@costrouc costrouc closed this Aug 8, 2018
@costrouc costrouc deleted the costrouc/dask-jobqueue branch August 8, 2018 04:35
@FRidh
Copy link
Member

FRidh commented Aug 8, 2018

@costrouc don't, just create separate commits in a single PR.

@costrouc
Copy link
Member Author

costrouc commented Aug 8, 2018 •
edited by dotlambda

@FRidh I have already done this sorry. Glad to learn that this is the way. Definitely will just do separate commits in the future because that is much much easier.

See these:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @dotlambda @FRidh @GrahamcOfBorg