Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gobby5: fix build #44651

Merged
merged 2 commits into from Aug 12, 2018
Merged

gobby5: fix build #44651

merged 2 commits into from Aug 12, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 8, 2018 •
edited

Motivation for this change

Had to update it to unstable in order to be able to build with the current libinfinity.

I also had to switch libinfinity to gtk3, since gtk2 support was removed. While at it, I modernized the package a bit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @Phreedom (maintainer)

@jtojnar
libinfinity: modernize expression
4ce95e4 
* Use multiple outputs to reduce the number of rebuilds necessary.
* Fix build with GTK+ support
@jtojnar
gobby5: 0.5.0 → unstable-2018-04-03
59a2753 
fix build
@jtojnar jtojnar requested a review from Phreedom August 8, 2018 01:05
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: libinfinity

The following builds were skipped because they don't evaluate on x86_64-darwin: gobby5

Partial log (click to expand)

Command '[u'/private/tmp/nix-build-libinfinity-0.7.1.drv-0/libinfinity-0.7.1/libinfinity/tmp-introspectuI6Mo1/Infinity-0.7', u'--introspect-dump=/private/tmp/nix-build-libinfinity-0.7.1.drv-0/libinfinity-0.7.1/libinfinity/tmp-introspectuI6Mo1/functions.txt,/private/tmp/nix-build-libinfinity-0.7.1.drv-0/libinfinity-0.7.1/libinfinity/tmp-introspectuI6Mo1/dump.xml']' returned non-zero exit status -11
make[3]: *** [/nix/store/zhrmdbcq2gx1qlcdffsrmraxaiy92xr5-gobject-introspection-1.56.0/share/gobject-introspection-1.0/Makefile.introspection:160: Infinity-0.7.gir] Error 1
make[3]: Leaving directory '/private/tmp/nix-build-libinfinity-0.7.1.drv-0/libinfinity-0.7.1/libinfinity'
make[2]: *** [Makefile:773: all] Error 2
make[2]: Leaving directory '/private/tmp/nix-build-libinfinity-0.7.1.drv-0/libinfinity-0.7.1/libinfinity'
make[1]: *** [Makefile:533: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-libinfinity-0.7.1.drv-0/libinfinity-0.7.1'
make: *** [Makefile:434: all] Error 2
builder for '/nix/store/5jmnimx13lxghg5phmaixkh8klxprsw4-libinfinity-0.7.1.drv' failed with exit code 2
error: build of '/nix/store/5jmnimx13lxghg5phmaixkh8klxprsw4-libinfinity-0.7.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gobby5, libinfinity

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/3x5gx11pkrbarygiazqiw7d59wh5cbfh-gobby-unstable-2018-04-03/bin/gobby-0.5
shrinking RPATHs of ELF executables and libraries in /nix/store/3x5gx11pkrbarygiazqiw7d59wh5cbfh-gobby-unstable-2018-04-03
shrinking /nix/store/3x5gx11pkrbarygiazqiw7d59wh5cbfh-gobby-unstable-2018-04-03/bin/.gobby-0.5-wrapped
gzipping man pages under /nix/store/3x5gx11pkrbarygiazqiw7d59wh5cbfh-gobby-unstable-2018-04-03/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3x5gx11pkrbarygiazqiw7d59wh5cbfh-gobby-unstable-2018-04-03/bin
patching script interpreter paths in /nix/store/3x5gx11pkrbarygiazqiw7d59wh5cbfh-gobby-unstable-2018-04-03
checking for references to /build in /nix/store/3x5gx11pkrbarygiazqiw7d59wh5cbfh-gobby-unstable-2018-04-03...

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gobby5, libinfinity

Partial log (click to expand)

   Compiling rls-span v0.4.0
   Compiling rls-data v0.15.0
   Compiling rustc_errors v0.0.0 (file:///build/rustc-1.27.0-src/src/librustc_errors)
   Compiling backtrace v0.3.6
building of '/nix/store/nzxz2hn6ssvanp1v6ayprfbprlvx1sf3-rustc-1.27.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/746np0zvbhpa2sr6vkkkpnwsgb9dxdga-cargo-1.27.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/q28r339dz25l1mmw8rfbkz1ldcczwzmj-librsvg-2.42.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/y3j81m2w0m8ziyz6c0an81icgrxfxh31-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/k1wkgyqvf1ii7s1pjig7xp3lym6kf7f6-gobby-unstable-2018-04-03.drv': 1 dependencies couldn't be built
error: build of '/nix/store/k1wkgyqvf1ii7s1pjig7xp3lym6kf7f6-gobby-unstable-2018-04-03.drv' failed

@jtojnar jtojnar merged commit f496d26 into NixOS:master Aug 12, 2018
@jtojnar jtojnar deleted the gobby branch September 13, 2018 23:04
@jtojnar jtojnar mentioned this pull request Jan 29, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @GrahamcOfBorg