Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tt-rss-theme-feedly: Init at 1.4.0 #44634

Merged
merged 1 commit into from Aug 7, 2018
Merged

tt-rss-theme-feedly: Init at 1.4.0 #44634

merged 1 commit into from Aug 7, 2018

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Aug 7, 2018

Motivation for this change

I use the theme every day because the default one looks crappy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

pSub
pSub requested changes Aug 7, 2018
View reviewed changes
pkgs/servers/tt-rss/theme-feedly/default.nix Outdated
@@ -0,0 +1,25 @@
{ stdenv, fetchFromGitHub, ... }: stdenv.mkDerivation rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need ... here. AFAIK the use of ... is discouraged as well.

pkgs/servers/tt-rss/theme-feedly/default.nix Outdated
sha256 = "1n5vci84l0wxsd2k90m2x3j8d7y9kz5fqc6fk6y7r568p1cakg9b";
};

installPhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add dontBuild = true to skip the build phase.

@xeji
Copy link
Contributor

xeji commented Aug 7, 2018

@GrahamcOfBorg build tt-rss-theme-feedly

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: tt-rss-theme-feedly

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/6ib5w6g3rd89q5bs56l4g9v8g2p977ys-tt-rss-theme-feedly-1.4.0
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/6ib5w6g3rd89q5bs56l4g9v8g2p977ys-tt-rss-theme-feedly-1.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tt-rss-theme-feedly

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1z8ky71kkpm1i908cx0iq7c0d6dwyp9x-tt-rss-theme-feedly-1.4.0
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/1z8ky71kkpm1i908cx0iq7c0d6dwyp9x-tt-rss-theme-feedly-1.4.0
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/1z8ky71kkpm1i908cx0iq7c0d6dwyp9x-tt-rss-theme-feedly-1.4.0...
/nix/store/1z8ky71kkpm1i908cx0iq7c0d6dwyp9x-tt-rss-theme-feedly-1.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tt-rss-theme-feedly

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ni93gb99k2yqzqldrdq4ryzz3cwwlnfk-tt-rss-theme-feedly-1.4.0
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ni93gb99k2yqzqldrdq4ryzz3cwwlnfk-tt-rss-theme-feedly-1.4.0
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/ni93gb99k2yqzqldrdq4ryzz3cwwlnfk-tt-rss-theme-feedly-1.4.0...
/nix/store/ni93gb99k2yqzqldrdq4ryzz3cwwlnfk-tt-rss-theme-feedly-1.4.0

@dasJ
Copy link
Member Author

dasJ commented Aug 7, 2018

@pSub Fixed

@xeji
Copy link
Contributor

xeji commented Aug 7, 2018

@GrahamcOfBorg build tt-rss-theme-feedly

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: tt-rss-theme-feedly

Partial log (click to expand)

no configure script, doing nothing
installing
post-installation fixup
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/0lly2i1zjwc5582369cm707cc3qqh9cz-tt-rss-theme-feedly-1.4.0
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/0lly2i1zjwc5582369cm707cc3qqh9cz-tt-rss-theme-feedly-1.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tt-rss-theme-feedly

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cj9zzj90pgv3p9gjcvxahj7s4xz9jbrp-tt-rss-theme-feedly-1.4.0
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/cj9zzj90pgv3p9gjcvxahj7s4xz9jbrp-tt-rss-theme-feedly-1.4.0
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/cj9zzj90pgv3p9gjcvxahj7s4xz9jbrp-tt-rss-theme-feedly-1.4.0...
/nix/store/cj9zzj90pgv3p9gjcvxahj7s4xz9jbrp-tt-rss-theme-feedly-1.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tt-rss-theme-feedly

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ki3iid143x3jwwm3q2wcjrk5g8ni7mgp-tt-rss-theme-feedly-1.4.0
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ki3iid143x3jwwm3q2wcjrk5g8ni7mgp-tt-rss-theme-feedly-1.4.0
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/ki3iid143x3jwwm3q2wcjrk5g8ni7mgp-tt-rss-theme-feedly-1.4.0...
/nix/store/ki3iid143x3jwwm3q2wcjrk5g8ni7mgp-tt-rss-theme-feedly-1.4.0

@xeji xeji merged commit 022b81f into NixOS:master Aug 7, 2018
@dasJ dasJ deleted the tt-rss-feedly branch August 7, 2018 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dasJ @xeji @GrahamcOfBorg @pSub