Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nwjs: 0.23.6 -> 0.32.1 #44676

Merged
merged 1 commit into from Aug 12, 2018
Merged

nwjs: 0.23.6 -> 0.32.1 #44676

merged 1 commit into from Aug 12, 2018

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Aug 8, 2018

Motivation for this change

New version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" (tested gitter compilation and its execution)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji xeji mentioned this pull request Aug 8, 2018
Closed
@samueldr
Copy link
Member

Hi, thanks for the update.

Let's see the build status on different platforms. It all built locally for me.

@GrahamcOfBorg build nwjs

Additionally, nox-review doesn't see anything depending on nwjs, only thing found with ag is a dead reference in gitter's derivation's parameters.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: nwjs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nwjs

Partial log (click to expand)

/nix/store/ysnq3rj7pakaa1pxkqfqcwl6g6kk225r-nwjs-0.32.1/share/nwjs/locales/ro.pak
/nix/store/ysnq3rj7pakaa1pxkqfqcwl6g6kk225r-nwjs-0.32.1/share/nwjs/locales/zh-CN.pak
/nix/store/ysnq3rj7pakaa1pxkqfqcwl6g6kk225r-nwjs-0.32.1/share/nwjs/locales/es.pak
/nix/store/ysnq3rj7pakaa1pxkqfqcwl6g6kk225r-nwjs-0.32.1/share/nwjs/locales/ru.pak
/nix/store/ysnq3rj7pakaa1pxkqfqcwl6g6kk225r-nwjs-0.32.1/share/nwjs/locales/et.pak
/nix/store/ysnq3rj7pakaa1pxkqfqcwl6g6kk225r-nwjs-0.32.1/share/nwjs/locales/ko.pak.info
/nix/store/ysnq3rj7pakaa1pxkqfqcwl6g6kk225r-nwjs-0.32.1/share/nwjs/locales/nb.pak.info
/nix/store/ysnq3rj7pakaa1pxkqfqcwl6g6kk225r-nwjs-0.32.1/share/nwjs/icudtl.dat
warning: working around a Linux kernel bug by creating a hole of 8192 bytes in ‘/nix/store/ysnq3rj7pakaa1pxkqfqcwl6g6kk225r-nwjs-0.32.1/share/nwjs/nw’
/nix/store/ysnq3rj7pakaa1pxkqfqcwl6g6kk225r-nwjs-0.32.1

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: nwjs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@samueldr samueldr merged commit a3722a6 into NixOS:master Aug 12, 2018
@samueldr samueldr mentioned this pull request Aug 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yrashk @samueldr @GrahamcOfBorg