Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc-audio-processing: 0.3 -> 0.3.1 #44680

Merged
merged 1 commit into from Aug 8, 2018

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Aug 8, 2018

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/webrtc-audio-processing/versions.

meta.description for webrtc-audio-processing is: '"A more Linux packaging friendly copy of the AudioProcessing module from the WebRTC project"'.

Checks done (click to expand)
Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:

cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:

git fetch r-ryantm && git checkout 68c28605d43ce3a133fda3b72d002673c7e9a0b6 && nix-shell --pure -I nixpkgs=. -p webrtc-audio-processing

cc @wkennington for testing.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: webrtc-audio-processing

Partial log (click to expand)

#include <ApplicationServices/ApplicationServices.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [Makefile:629: source/libsystem_wrappers_la-event.lo] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-webrtc-audio-processing-0.3.1.drv-0/webrtc-audio-processing-0.3.1/webrtc/system_wrappers'
make[1]: *** [Makefile:460: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-webrtc-audio-processing-0.3.1.drv-0/webrtc-audio-processing-0.3.1/webrtc'
make: *** [Makefile:493: all-recursive] Error 1
builder for '/nix/store/i7pbhjn04vas6h8mfjjn49p25y6w0g1z-webrtc-audio-processing-0.3.1.drv' failed with exit code 2
error: build of '/nix/store/i7pbhjn04vas6h8mfjjn49p25y6w0g1z-webrtc-audio-processing-0.3.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: webrtc-audio-processing

Partial log (click to expand)

make[2]: Leaving directory '/build/webrtc-audio-processing-0.3.1'
make[1]: Leaving directory '/build/webrtc-audio-processing-0.3.1'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zwpizssdngqwan54s1ramkdp8aid49r0-webrtc-audio-processing-0.3.1
shrinking /nix/store/zwpizssdngqwan54s1ramkdp8aid49r0-webrtc-audio-processing-0.3.1/lib/libwebrtc_audio_processing.so.1.0.0
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zwpizssdngqwan54s1ramkdp8aid49r0-webrtc-audio-processing-0.3.1/lib
patching script interpreter paths in /nix/store/zwpizssdngqwan54s1ramkdp8aid49r0-webrtc-audio-processing-0.3.1
checking for references to /build in /nix/store/zwpizssdngqwan54s1ramkdp8aid49r0-webrtc-audio-processing-0.3.1...
/nix/store/zwpizssdngqwan54s1ramkdp8aid49r0-webrtc-audio-processing-0.3.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: webrtc-audio-processing

Partial log (click to expand)

make[2]: Leaving directory '/build/webrtc-audio-processing-0.3.1'
make[1]: Leaving directory '/build/webrtc-audio-processing-0.3.1'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kwmc8x6qqh8fkfla0xv7zlanw4wf8klf-webrtc-audio-processing-0.3.1
shrinking /nix/store/kwmc8x6qqh8fkfla0xv7zlanw4wf8klf-webrtc-audio-processing-0.3.1/lib/libwebrtc_audio_processing.so.1.0.0
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kwmc8x6qqh8fkfla0xv7zlanw4wf8klf-webrtc-audio-processing-0.3.1/lib
patching script interpreter paths in /nix/store/kwmc8x6qqh8fkfla0xv7zlanw4wf8klf-webrtc-audio-processing-0.3.1
checking for references to /build in /nix/store/kwmc8x6qqh8fkfla0xv7zlanw4wf8klf-webrtc-audio-processing-0.3.1...
/nix/store/kwmc8x6qqh8fkfla0xv7zlanw4wf8klf-webrtc-audio-processing-0.3.1

@jtojnar jtojnar force-pushed the auto-update/webrtc-audio-processing branch from 68c2860 to ee9d50c Compare August 8, 2018 10:19
@jtojnar
Copy link
Contributor

jtojnar commented Aug 8, 2018

The aarch32 test no longer applies after https://cgit.freedesktop.org/pulseaudio/webrtc-audio-processing/commit/?id=ff77a85c28564d939d554ba264480d1876cbc316

Was the issue fixed or do we need a new patch, @dezgeg?

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/webrtc-audio-processing/versions.

Also remove isAarch32 configure hack since it is no longer applicable after
https://cgit.freedesktop.org/pulseaudio/webrtc-audio-processing/commit/?id=ff77a85c28564d939d554ba264480d1876cbc316

Also fix Darwin build

Signed-off-by: Jan Tojnar <jtojnar@gmail.com>
@jtojnar jtojnar force-pushed the auto-update/webrtc-audio-processing branch from ee9d50c to fbe47c8 Compare August 8, 2018 10:33
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: webrtc-audio-processing

Partial log (click to expand)

/nix/store/kwmc8x6qqh8fkfla0xv7zlanw4wf8klf-webrtc-audio-processing-0.3.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: webrtc-audio-processing

Partial log (click to expand)

/nix/store/zwpizssdngqwan54s1ramkdp8aid49r0-webrtc-audio-processing-0.3.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: webrtc-audio-processing

Partial log (click to expand)

/nix/store/05mh3shmqgygi5szh0pc40dsdq9jj5y8-webrtc-audio-processing-0.3.1/lib/libwebrtc_audio_processing.1.dylib: fixing dylib
/nix/store/05mh3shmqgygi5szh0pc40dsdq9jj5y8-webrtc-audio-processing-0.3.1/lib/libwebrtc_audio_processing.1.dylib: fixing dylib
/nix/store/05mh3shmqgygi5szh0pc40dsdq9jj5y8-webrtc-audio-processing-0.3.1/lib/libwebrtc_audio_processing.1.dylib: fixing dylib
/nix/store/05mh3shmqgygi5szh0pc40dsdq9jj5y8-webrtc-audio-processing-0.3.1/lib/libwebrtc_audio_processing.1.dylib: fixing dylib
/nix/store/05mh3shmqgygi5szh0pc40dsdq9jj5y8-webrtc-audio-processing-0.3.1/lib/libwebrtc_audio_processing.1.dylib: fixing dylib
/nix/store/05mh3shmqgygi5szh0pc40dsdq9jj5y8-webrtc-audio-processing-0.3.1/lib/libwebrtc_audio_processing.1.dylib: fixing dylib
/nix/store/05mh3shmqgygi5szh0pc40dsdq9jj5y8-webrtc-audio-processing-0.3.1/lib/libwebrtc_audio_processing.1.dylib: fixing dylib
/nix/store/05mh3shmqgygi5szh0pc40dsdq9jj5y8-webrtc-audio-processing-0.3.1/lib/libwebrtc_audio_processing.1.dylib: fixing dylib
/nix/store/05mh3shmqgygi5szh0pc40dsdq9jj5y8-webrtc-audio-processing-0.3.1/lib/libwebrtc_audio_processing.1.dylib: fixing dylib
/nix/store/05mh3shmqgygi5szh0pc40dsdq9jj5y8-webrtc-audio-processing-0.3.1

@dezgeg
Copy link
Contributor

dezgeg commented Aug 8, 2018

Let me try to compile it.

@dezgeg
Copy link
Contributor

dezgeg commented Aug 8, 2018

Seems like the issue was fixed upstream 👍

@jtojnar jtojnar merged commit 4ade136 into NixOS:master Aug 8, 2018
@r-ryantm r-ryantm deleted the auto-update/webrtc-audio-processing branch August 8, 2018 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants