Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beam-packages: default erlangR19 -> erlangR20 #44640

Merged
merged 2 commits into from Sep 1, 2018
Merged

beam-packages: default erlangR19 -> erlangR20 #44640

merged 2 commits into from Sep 1, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Aug 7, 2018 •
edited

Motivation for this change

This is probably a bit overdue by now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added this to the 18.09 milestone Aug 30, 2018
@LnL7
Copy link
Member Author

LnL7 commented Aug 31, 2018

Looks like cuter broke.

@LnL7
cuter: use erlangR19 and cleanp expression
85fdbf6 
It fails to build using R20 and there's no new release available.
@GrahamcOfBorg
Copy link

Success on x86_64-darwin [(full log)](https://logs.nix.ci/?key=nixos/nixpkgs.44640&attempt_id=631717ec-f087-4946-89f1-20071deaaad6)

Attempted: cuter

Partial log (click to expand)

/nix/store/wh6hgaiqgp97n944kj23bjm3nsq4zp5z-cuter-0.1/lib/erlang/lib/cuter-0.1/example.sh: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/wh6hgaiqgp97n944kj23bjm3nsq4zp5z-cuter-0.1/lib/erlang/lib/cuter-0.1/test/python_test: interpreter directive changed from "/usr/bin/env python" to "/nix/store/s9mj8zzg7b0zj7s0k4rx3hdsiayr3ckn-python-2.7.15/bin/python"
/nix/store/wh6hgaiqgp97n944kj23bjm3nsq4zp5z-cuter-0.1/lib/erlang/lib/cuter-0.1/test/eunit_test: interpreter directive changed from "/usr/bin/env python" to "/nix/store/s9mj8zzg7b0zj7s0k4rx3hdsiayr3ckn-python-2.7.15/bin/python"
/nix/store/wh6hgaiqgp97n944kj23bjm3nsq4zp5z-cuter-0.1/lib/erlang/lib/cuter-0.1/test/functional_test: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/wh6hgaiqgp97n944kj23bjm3nsq4zp5z-cuter-0.1/lib/erlang/lib/cuter-0.1/configure: interpreter directive changed from " /bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/wh6hgaiqgp97n944kj23bjm3nsq4zp5z-cuter-0.1/lib/erlang/lib/cuter-0.1/priv/cuter_interface.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/s9mj8zzg7b0zj7s0k4rx3hdsiayr3ckn-python-2.7.15/bin/python"
/nix/store/wh6hgaiqgp97n944kj23bjm3nsq4zp5z-cuter-0.1/lib/erlang/lib/cuter-0.1/priv/cuter_print.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/s9mj8zzg7b0zj7s0k4rx3hdsiayr3ckn-python-2.7.15/bin/python"
/nix/store/wh6hgaiqgp97n944kj23bjm3nsq4zp5z-cuter-0.1/lib/erlang/lib/cuter-0.1/priv/cuter_solve_offline.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/s9mj8zzg7b0zj7s0k4rx3hdsiayr3ckn-python-2.7.15/bin/python"
/nix/store/wh6hgaiqgp97n944kj23bjm3nsq4zp5z-cuter-0.1/lib/erlang/lib/cuter-0.1/cuter: interpreter directive changed from "/usr/bin/env python" to "/nix/store/s9mj8zzg7b0zj7s0k4rx3hdsiayr3ckn-python-2.7.15/bin/python"
/nix/store/wh6hgaiqgp97n944kj23bjm3nsq4zp5z-cuter-0.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cuter

Partial log (click to expand)

/nix/store/fk2cai05l6g97mcw2awg2k3x8x06h35y-cuter-0.1/lib/erlang/lib/cuter-0.1/priv/cuter_solve_offline.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/6b6lzbq74g95j8qlbrdjzkn2ghh81mgy-python-2.7.15/bin/python"
/nix/store/fk2cai05l6g97mcw2awg2k3x8x06h35y-cuter-0.1/lib/erlang/lib/cuter-0.1/priv/cuter_print.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/6b6lzbq74g95j8qlbrdjzkn2ghh81mgy-python-2.7.15/bin/python"
/nix/store/fk2cai05l6g97mcw2awg2k3x8x06h35y-cuter-0.1/lib/erlang/lib/cuter-0.1/priv/cuter_interface.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/6b6lzbq74g95j8qlbrdjzkn2ghh81mgy-python-2.7.15/bin/python"
/nix/store/fk2cai05l6g97mcw2awg2k3x8x06h35y-cuter-0.1/lib/erlang/lib/cuter-0.1/test/eunit_test: interpreter directive changed from "/usr/bin/env python" to "/nix/store/6b6lzbq74g95j8qlbrdjzkn2ghh81mgy-python-2.7.15/bin/python"
/nix/store/fk2cai05l6g97mcw2awg2k3x8x06h35y-cuter-0.1/lib/erlang/lib/cuter-0.1/test/functional_test: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/fk2cai05l6g97mcw2awg2k3x8x06h35y-cuter-0.1/lib/erlang/lib/cuter-0.1/test/python_test: interpreter directive changed from "/usr/bin/env python" to "/nix/store/6b6lzbq74g95j8qlbrdjzkn2ghh81mgy-python-2.7.15/bin/python"
/nix/store/fk2cai05l6g97mcw2awg2k3x8x06h35y-cuter-0.1/lib/erlang/lib/cuter-0.1/example.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/fk2cai05l6g97mcw2awg2k3x8x06h35y-cuter-0.1/bin/.cuter-wrapped: interpreter directive changed from "/usr/bin/env python" to "/nix/store/6b6lzbq74g95j8qlbrdjzkn2ghh81mgy-python-2.7.15/bin/python"
checking for references to /build in /nix/store/fk2cai05l6g97mcw2awg2k3x8x06h35y-cuter-0.1...
/nix/store/fk2cai05l6g97mcw2awg2k3x8x06h35y-cuter-0.1

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: cuter

Partial log (click to expand)

xsltproc --output "../man3/wxGridCellBoolRenderer.3" --stringparam company "Ericsson AB" --stringparam docgen "/build/source/bootstrap/lib/erl_docgen" --stringparam gendate "$date" --stringparam appname "wx" --stringparam appver "1.8" --stringparam specs_file "$specs_file" --xinclude -path /build/source/bootstrap/lib/erl_docgen/priv/dtd  -path /build/source/bootstrap/lib/erl_docgen/priv/dtd_man_entities /build/source/bootstrap/lib/erl_docgen/priv/xsl/db_man.xsl wxGridCellBoolRenderer.xml
date=`date +"%B %e, %Y"`; \
specs_file=`pwd`/../specs/specs_wxGridCellChoiceEditor.xml; \
xsltproc --output "../man3/wxGridCellChoiceEditor.3" --stringparam company "Ericsson AB" --stringparam docgen "/build/source/bootstrap/lib/erl_docgen" --stringparam gendate "$date" --stringparam appname "wx" --stringparam appver "1.8" --stringparam specs_file "$specs_file" --xinclude -path /build/source/bootstrap/lib/erl_docgen/priv/dtd  -path /build/source/bootstrap/lib/erl_docgen/priv/dtd_man_entities /build/source/bootstrap/lib/erl_docgen/priv/xsl/db_man.xsl wxGridCellChoiceEditor.xml
date=`date +"%B %e, %Y"`; \
specs_file=`pwd`/../specs/specs_wxGridCellEditor.xml; \
xsltproc --output "../man3/wxGridCellEditor.3" --stringparam company "Ericsson AB" --stringparam docgen "/build/source/bootstrap/lib/erl_docgen" --stringparam gendate "$date" --stringparam appname "wx" --stringparam appver "1.8" --stringparam specs_file "$specs_file" --xinclude -path /build/source/bootstrap/lib/erl_docgen/priv/dtd  -path /build/source/bootstrap/lib/erl_docgen/priv/dtd_man_entities /build/source/bootstrap/lib/erl_docgen/priv/xsl/db_man.xsl wxGridCellEditor.xml
building of '/nix/store/axfl1nisq17vzv7r5bqnc80xzn01ch5r-erlang-19.3.6.6.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/7i9bw47lvdlskg5s9n76jrdqp2ysibzv-cuter-0.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/7i9bw47lvdlskg5s9n76jrdqp2ysibzv-cuter-0.1.drv' failed

@LnL7 LnL7 merged commit 9e2e667 into NixOS:master Sep 1, 2018
@LnL7 LnL7 deleted the beam-erlangR20 branch September 1, 2018 12:24
@yorickvP yorickvP mentioned this pull request Jul 15, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: erlang 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
18.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LnL7 @GrahamcOfBorg