Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qstopmotion: 2.3.2 -> 2.4.0 #44642

Merged
merged 1 commit into from Aug 12, 2018
Merged

qstopmotion: 2.3.2 -> 2.4.0 #44642

merged 1 commit into from Aug 12, 2018

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented Aug 7, 2018

Motivation for this change

Version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 7, 2018

@GrahamcOfBorg build qstopmotion

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: qstopmotion

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qstopmotion

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pzwi0s5jpzpw0rbwy9n9r65h8jrczc6x-qstopmotion-2.4.0
/nix/store/pzwi0s5jpzpw0rbwy9n9r65h8jrczc6x-qstopmotion-2.4.0
shrinking /nix/store/pzwi0s5jpzpw0rbwy9n9r65h8jrczc6x-qstopmotion-2.4.0/bin/qstopmotion
gzipping man pages under /nix/store/pzwi0s5jpzpw0rbwy9n9r65h8jrczc6x-qstopmotion-2.4.0/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pzwi0s5jpzpw0rbwy9n9r65h8jrczc6x-qstopmotion-2.4.0/bin
patching script interpreter paths in /nix/store/pzwi0s5jpzpw0rbwy9n9r65h8jrczc6x-qstopmotion-2.4.0
checking for references to /build in /nix/store/pzwi0s5jpzpw0rbwy9n9r65h8jrczc6x-qstopmotion-2.4.0...
postPatchMkspecs

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: qstopmotion

Partial log (click to expand)

[73/80] Building CXX object CMakeFiles/qstopmotion.dir/src/technical/grabber/imagegrabberfacade.cpp.o
[74/80] Building CXX object CMakeFiles/qstopmotion.dir/src/frontends/qtfrontend/preferences/projectwidget.cpp.o
[75/80] Building CXX object CMakeFiles/qstopmotion.dir/src/technical/grabber/video4linux2/v4l2grabber.cpp.o
[76/80] Building CXX object CMakeFiles/qstopmotion.dir/src/domain/animation/animationproject.cpp.o
[77/80] Building CXX object CMakeFiles/qstopmotion.dir/src/domain/animation/scene.cpp.o
[78/80] Building CXX object CMakeFiles/qstopmotion.dir/src/frontends/qtfrontend/dialogs/cameracontrollerdialog.cpp.o
[79/80] Building CXX object CMakeFiles/qstopmotion.dir/src/frontends/qtfrontend/qtfrontend.cpp.o
ninja: build stopped: subcommand failed.
builder for '/nix/store/h8jn3a3xjh6dfcwwrryd34fnhmmw6q58-qstopmotion-2.4.0.drv' failed with exit code 1
error: build of '/nix/store/h8jn3a3xjh6dfcwwrryd34fnhmmw6q58-qstopmotion-2.4.0.drv' failed

samueldr
samueldr approved these changes Aug 11, 2018
View reviewed changes
Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aarch64-linux failure isn't new, verified on bf1b50c, current nixpkgs-unstable HEAD.

@xeji xeji merged commit 3703799 into NixOS:master Aug 12, 2018
@leenaars leenaars deleted the qstopmotion branch August 12, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leenaars @xeji @GrahamcOfBorg @samueldr