keybase: 2.1.0 -> 2.5.0 #44698

colemickens · 2018-08-08T09:28:47Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

xeji · 2018-08-08T22:00:16Z

@GrahamcOfBorg build keybase

GrahamcOfBorg · 2018-08-08T22:11:09Z

Success on x86_64-linux (full log)

Attempted: keybase

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7h6ffy40lg52hh9958zvy0g9i6693kk5-keybase-2.5.0-bin
shrinking /nix/store/7h6ffy40lg52hh9958zvy0g9i6693kk5-keybase-2.5.0-bin/bin/keybase
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7h6ffy40lg52hh9958zvy0g9i6693kk5-keybase-2.5.0-bin/bin
patching script interpreter paths in /nix/store/7h6ffy40lg52hh9958zvy0g9i6693kk5-keybase-2.5.0-bin
checking for references to /build in /nix/store/7h6ffy40lg52hh9958zvy0g9i6693kk5-keybase-2.5.0-bin...
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
/nix/store/7h6ffy40lg52hh9958zvy0g9i6693kk5-keybase-2.5.0-bin

GrahamcOfBorg · 2018-08-08T22:28:43Z

Failure on x86_64-darwin (full log)

Attempted: keybase

Partial log (click to expand)

         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
github.com/keybase/client/go/stellar/relays
github.com/keybase/client/go/saltpackkeys
github.com/keybase/client/go/git
github.com/keybase/client/go/ephemeral
github.com/keybase/client/go/stellar
github.com/keybase/client/go/stellar/stellarsvc
builder for '/nix/store/iflj0152v9dwxjm865cfn67ywdfnijp5-keybase-2.5.0.drv' failed with exit code 1
error: build of '/nix/store/iflj0152v9dwxjm865cfn67ywdfnijp5-keybase-2.5.0.drv' failed

xeji · 2018-08-08T22:32:35Z

Darwin failure is a regression, builds with current version.

colemickens · 2018-08-08T22:34:17Z

I can take a look, but I don't have a Mac and am not familiar with their toolchain/libraries/etc. We might want to find a related issue on keybase repo or file one, unless other folks have a solid idea. (Lots of SO hits, but I don't know what we would need to do for mitigation, etc)

GrahamcOfBorg · 2018-08-08T22:37:53Z

Success on aarch64-linux (full log)

Attempted: keybase

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/50d9bwaiqb6macza0xxh3k3rm0xyrr1n-keybase-2.5.0-bin
shrinking /nix/store/50d9bwaiqb6macza0xxh3k3rm0xyrr1n-keybase-2.5.0-bin/bin/keybase
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/50d9bwaiqb6macza0xxh3k3rm0xyrr1n-keybase-2.5.0-bin/bin
patching script interpreter paths in /nix/store/50d9bwaiqb6macza0xxh3k3rm0xyrr1n-keybase-2.5.0-bin
checking for references to /build in /nix/store/50d9bwaiqb6macza0xxh3k3rm0xyrr1n-keybase-2.5.0-bin...
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
/nix/store/50d9bwaiqb6macza0xxh3k3rm0xyrr1n-keybase-2.5.0-bin

jonafato · 2018-08-09T01:55:22Z

@colemickens That Darwin failure is due to missing AVFoundation, which appears to be a recently added dependency. If you add it conditionally (similarly to how is done for qtox), it should build.

colemickens · 2018-08-09T07:48:51Z

Alright, I've attempted the change. Builds under Linux. I don't think I'm trusted, but I'm going to try anyway...

@GrahamcOfBorg build keybase

btw: thank you for the explanation and pointers @jonafato

xeji · 2018-08-09T08:08:02Z

@GrahamcOfBorg build keybase

GrahamcOfBorg · 2018-08-09T08:19:09Z

Success on x86_64-linux (full log)

Attempted: keybase

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zaxrnppzyisx1j6ja1s8kmp2h1idfhya-keybase-2.5.0-bin
shrinking /nix/store/zaxrnppzyisx1j6ja1s8kmp2h1idfhya-keybase-2.5.0-bin/bin/keybase
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zaxrnppzyisx1j6ja1s8kmp2h1idfhya-keybase-2.5.0-bin/bin
patching script interpreter paths in /nix/store/zaxrnppzyisx1j6ja1s8kmp2h1idfhya-keybase-2.5.0-bin
checking for references to /build in /nix/store/zaxrnppzyisx1j6ja1s8kmp2h1idfhya-keybase-2.5.0-bin...
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
/nix/store/zaxrnppzyisx1j6ja1s8kmp2h1idfhya-keybase-2.5.0-bin

GrahamcOfBorg · 2018-08-09T08:26:27Z

Success on aarch64-linux (full log)

Attempted: keybase

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xd35ixghpnznm0xbvjmlja5rics4nrwd-keybase-2.5.0-bin
shrinking /nix/store/xd35ixghpnznm0xbvjmlja5rics4nrwd-keybase-2.5.0-bin/bin/keybase
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xd35ixghpnznm0xbvjmlja5rics4nrwd-keybase-2.5.0-bin/bin
patching script interpreter paths in /nix/store/xd35ixghpnznm0xbvjmlja5rics4nrwd-keybase-2.5.0-bin
checking for references to /build in /nix/store/xd35ixghpnznm0xbvjmlja5rics4nrwd-keybase-2.5.0-bin...
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
/nix/store/xd35ixghpnznm0xbvjmlja5rics4nrwd-keybase-2.5.0-bin

GrahamcOfBorg · 2018-08-09T10:02:32Z

Failure on x86_64-darwin (full log)

Attempted: keybase

Partial log (click to expand)

         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
github.com/keybase/client/go/stellar/relays
github.com/keybase/client/go/saltpackkeys
github.com/keybase/client/go/git
github.com/keybase/client/go/ephemeral
github.com/keybase/client/go/stellar
github.com/keybase/client/go/stellar/stellarsvc
builder for '/nix/store/80013yivnc6llnnmi7x5ksfshlf2rf1q-keybase-2.5.0.drv' failed with exit code 1
error: build of '/nix/store/80013yivnc6llnnmi7x5ksfshlf2rf1q-keybase-2.5.0.drv' failed

colemickens · 2018-08-09T10:09:51Z

Hm, I'm not sure why it doesn't work. Any more suggestions?

xeji · 2018-08-09T10:12:34Z

~~Timeout on darwin. Let's merge anyway and see how this works on Hydra.~~
Sorry, my mistake, looked in the wrong tab.

xeji · 2018-08-09T10:18:00Z

You might need to inherit AVFoundation from the apple frameworks, like here

colemickens · 2018-08-19T17:08:24Z

@GrahamcOfBorg build keybase

infinisil · 2018-08-19T17:50:15Z

@GrahamcOfBorg build keybase

(not everybody can start builds)

GrahamcOfBorg · 2018-08-19T17:50:39Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: keybase

Partial log (click to expand)

Cannot nix-instantiate `keybase' because:
error: while evaluating 'callPackageWith' at /var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/lib/customisation.nix:108:35, called from /var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/pkgs/top-level/all-packages.nix:3404:13:
while evaluating 'makeOverridable' at /var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/lib/customisation.nix:67:24, called from /var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/lib/customisation.nix:112:8:
syntax error, unexpected '.', expecting '}', at /var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/pkgs/tools/security/keybase/default.nix:1:55

GrahamcOfBorg · 2018-08-19T17:50:46Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: keybase

Partial log (click to expand)

Cannot nix-instantiate `keybase' because:
error: while evaluating 'callPackageWith' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:3404:13:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:112:8:
syntax error, unexpected '.', expecting '}', at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/tools/security/keybase/default.nix:1:55

GrahamcOfBorg · 2018-08-19T17:50:47Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: keybase

Partial log (click to expand)

Cannot nix-instantiate `keybase' because:
error: while evaluating 'callPackageWith' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/customisation.nix:108:35, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/top-level/all-packages.nix:3404:13:
while evaluating 'makeOverridable' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/customisation.nix:67:24, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/customisation.nix:112:8:
syntax error, unexpected '.', expecting '}', at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/tools/security/keybase/default.nix:1:55

infinisil · 2018-08-19T17:52:30Z

pkgs/tools/security/keybase/default.nix

@@ -1,8 +1,8 @@
-{ stdenv, buildGoPackage, fetchFromGitHub }:
+{ stdenv, lib, buildGoPackage, fetchFromGitHub, darwin.apple_sdk.frameworks.AVFoundation ? null }:


Oh but this is not even valid syntax. You should've noticed this locally already. Look at the file @xeji linked and replicate that in all-packages.nix, then this line here should just be AVFoundation ? null

colemickens · 2018-08-22T20:04:37Z

Sorry about the bad syntax. I'd cloned another copy of the repo and forgot I wasn't building/evaling from it.

I've more closely followed the recommended pattern for pulling in the required library on Darwin/osx. Can someone spot check it and kick off the test again?

Thanks.

xeji · 2018-08-22T20:10:21Z

@GrahamcOfBorg build keybase

GrahamcOfBorg · 2018-08-22T20:11:25Z

Failure on x86_64-darwin (full log)

Attempted: keybase

Partial log (click to expand)

        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
github.com/keybase/client/go/stellar/relays
github.com/keybase/client/go/saltpackkeys
github.com/keybase/client/go/git
github.com/keybase/client/go/ephemeral
github.com/keybase/client/go/stellar
github.com/keybase/client/go/stellar/stellarsvc
builder for '/nix/store/bgzv5lfykc0wrg24c8fkjrsiq6xh55kq-keybase-2.5.0.drv' failed with exit code 1
error: build of '/nix/store/bgzv5lfykc0wrg24c8fkjrsiq6xh55kq-keybase-2.5.0.drv' failed

GrahamcOfBorg · 2018-08-22T20:12:16Z

Success on x86_64-linux (full log)

Attempted: keybase

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin
shrinking /nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin/bin/keybase
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
stripping (with command /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip and flags -S) in /nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin/bin
patching script interpreter paths in /nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin
checking for references to /build in /nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin...
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
/nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin

GrahamcOfBorg · 2018-08-22T20:13:05Z

Success on aarch64-linux (full log)

Attempted: keybase

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vn0yiljaxzm8cjspfy94f3dwm3b73r9q-keybase-2.5.0-bin
shrinking /nix/store/vn0yiljaxzm8cjspfy94f3dwm3b73r9q-keybase-2.5.0-bin/bin/keybase
/nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip is /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip
stripping (with command /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip and flags -S) in /nix/store/vn0yiljaxzm8cjspfy94f3dwm3b73r9q-keybase-2.5.0-bin/bin
patching script interpreter paths in /nix/store/vn0yiljaxzm8cjspfy94f3dwm3b73r9q-keybase-2.5.0-bin
checking for references to /build in /nix/store/vn0yiljaxzm8cjspfy94f3dwm3b73r9q-keybase-2.5.0-bin...
/nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip is /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip
/nix/store/vn0yiljaxzm8cjspfy94f3dwm3b73r9q-keybase-2.5.0-bin

xeji · 2018-08-22T20:18:33Z

We're slowly getting there. You also need to inherit AudioToolbox from (darwin.apple_sdk.frameworks).

colemickens · 2018-08-22T20:18:39Z

@xeji Thanks. Want to kick it again? I added AudioToolbox, tried to follow the same pattern.

edit: I need to edit top-level too, one second.

colemickens · 2018-08-22T20:20:15Z

@xeji updated, ptal. Thanks for the guidance and patience.

xeji · 2018-08-22T20:20:21Z

@GrahamcOfBorg build keybase

GrahamcOfBorg · 2018-08-22T20:20:50Z

Success on aarch64-linux (full log)

Attempted: keybase

Partial log (click to expand)

/nix/store/vn0yiljaxzm8cjspfy94f3dwm3b73r9q-keybase-2.5.0-bin

GrahamcOfBorg · 2018-08-22T20:21:05Z

Failure on x86_64-darwin (full log)

Attempted: keybase

Partial log (click to expand)

        ^~~~~~~~~~~~~~~~~~~~
1 error generated.
github.com/keybase/client/go/stellar/relays
github.com/keybase/client/go/saltpackkeys
github.com/keybase/client/go/git
github.com/keybase/client/go/ephemeral
github.com/keybase/client/go/stellar
github.com/keybase/client/go/stellar/stellarsvc
builder for '/nix/store/yanyq98bmzrr73kdn986pxbsk95c4mdp-keybase-2.5.0.drv' failed with exit code 1
error: build of '/nix/store/yanyq98bmzrr73kdn986pxbsk95c4mdp-keybase-2.5.0.drv' failed

GrahamcOfBorg · 2018-08-22T20:22:01Z

Success on x86_64-linux (full log)

Attempted: keybase

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin
shrinking /nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin/bin/keybase
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
stripping (with command /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip and flags -S) in /nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin/bin
patching script interpreter paths in /nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin
checking for references to /build in /nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin...
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
/nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin

xeji · 2018-08-22T20:22:28Z

CoreMedia as well ...
This is tedious, but I don't have a Mac either.

jonafato · 2018-08-22T20:27:49Z

This appears to be a list of the frameworks we need to include: https://github.com/keybase/client/blob/68bb8c893c5214040d86ea36f2f86fbb7fac8d39/go/chat/attachments/preview_darwin.go#L7.

colemickens · 2018-08-22T20:28:32Z

Done. (I would've thought AVFoundation would require those things, those includes are from AVFoundation, not directly from Keybase... but I also don't know anything about these "Frameworks" or how Nix is setup to handle osx libs like this).

xeji · 2018-08-22T20:29:59Z

@GrahamcOfBorg build keybase

GrahamcOfBorg · 2018-08-22T20:30:11Z

Success on x86_64-linux (full log)

Attempted: keybase

Partial log (click to expand)

/nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin

GrahamcOfBorg · 2018-08-22T20:30:26Z

Success on aarch64-linux (full log)

Attempted: keybase

Partial log (click to expand)

/nix/store/vn0yiljaxzm8cjspfy94f3dwm3b73r9q-keybase-2.5.0-bin

GrahamcOfBorg · 2018-08-22T20:30:44Z

Failure on x86_64-darwin (full log)

Attempted: keybase

Partial log (click to expand)

        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
github.com/keybase/client/go/stellar/relays
github.com/keybase/client/go/saltpackkeys
github.com/keybase/client/go/git
github.com/keybase/client/go/ephemeral
github.com/keybase/client/go/stellar
github.com/keybase/client/go/stellar/stellarsvc
builder for '/nix/store/84wq68dzlii1bfyb5ax35gzd44lndrdw-keybase-2.5.0.drv' failed with exit code 1
error: build of '/nix/store/84wq68dzlii1bfyb5ax35gzd44lndrdw-keybase-2.5.0.drv' failed

xeji · 2018-08-22T20:32:54Z

@jonafato thanks! Hopefully including everything on that list will fix it.

colemickens · 2018-08-22T20:36:20Z

I'm concerned that list isn't exhaustive? It doesn't include MediaToolbox that it's complaining about now. And MediaToolbox is only used via QTKit which isn't a transitive framework of any of those listed in the link above.

Also, another question, it looks like MediaToolbox includes CoreMedia? Should I remove the CoreMedia when adding MediaToolbox or is that not how this works?

https://github.com/NixOS/nixpkgs/blob/master/pkgs/os-specific/darwin/apple-sdk/frameworks.nix#L77

For now I'm going to just add everything from the linked file (except CoreFoundation due to the warning in frameworks.nix), and MediaToolbox and will push. Unless someone tells me otherwise...

colemickens · 2018-08-22T20:44:57Z

Added a comment to all-packages.nix to describe why the included frameworks are there. It is as I described in my last comment.

Hopefully it builds this time?

xeji · 2018-08-22T20:45:53Z

Let's see
@GrahamcOfBorg build keybase

GrahamcOfBorg · 2018-08-22T20:46:04Z

Success on x86_64-linux (full log)

Attempted: keybase

Partial log (click to expand)

/nix/store/i461x1dcg2l9xx4l5sfcxzdi4nil72aw-keybase-2.5.0-bin

GrahamcOfBorg · 2018-08-22T20:46:24Z

Success on aarch64-linux (full log)

Attempted: keybase

Partial log (click to expand)

/nix/store/vn0yiljaxzm8cjspfy94f3dwm3b73r9q-keybase-2.5.0-bin

GrahamcOfBorg · 2018-08-22T20:46:53Z

Success on x86_64-darwin (full log)

Attempted: keybase

Partial log (click to expand)

find: '/nix/store/1c8whvhds7bz1pg2w6ir0z9ys55ahvs9-keybase-2.5.0': No such file or directory
find: '/nix/store/1c8whvhds7bz1pg2w6ir0z9ys55ahvs9-keybase-2.5.0': No such file or directory
find: '/nix/store/1c8whvhds7bz1pg2w6ir0z9ys55ahvs9-keybase-2.5.0': No such file or directory
find: '/nix/store/1c8whvhds7bz1pg2w6ir0z9ys55ahvs9-keybase-2.5.0': No such file or directory
find: '/nix/store/1c8whvhds7bz1pg2w6ir0z9ys55ahvs9-keybase-2.5.0': No such file or directory
find: '/nix/store/1c8whvhds7bz1pg2w6ir0z9ys55ahvs9-keybase-2.5.0': No such file or directory
find: '/nix/store/1c8whvhds7bz1pg2w6ir0z9ys55ahvs9-keybase-2.5.0': No such file or directory
find: '/nix/store/1c8whvhds7bz1pg2w6ir0z9ys55ahvs9-keybase-2.5.0': No such file or directory
find: '/nix/store/1c8whvhds7bz1pg2w6ir0z9ys55ahvs9-keybase-2.5.0': No such file or directory
/nix/store/qaxfna14qm7ryhilhrzs228w9xk60d7y-keybase-2.5.0-bin

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 8, 2018

colemickens force-pushed the keybase branch from ac89585 to 2b1ff33 Compare August 9, 2018 07:48

colemickens force-pushed the keybase branch from 2b1ff33 to 2f2c7a7 Compare August 19, 2018 17:08

infinisil reviewed Aug 19, 2018

View reviewed changes

colemickens force-pushed the keybase branch from 2f2c7a7 to 689b8bc Compare August 20, 2018 06:04

colemickens force-pushed the keybase branch from 689b8bc to f3eb6de Compare August 22, 2018 20:17

colemickens force-pushed the keybase branch from f3eb6de to a9d39cd Compare August 22, 2018 20:19

colemickens force-pushed the keybase branch from a9d39cd to 1100803 Compare August 22, 2018 20:26

keybase: 2.1.0 -> 2.5.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

20edd56

colemickens force-pushed the keybase branch from 1100803 to 20edd56 Compare August 22, 2018 20:43

xeji merged commit 6d64024 into NixOS:master Aug 22, 2018

colemickens deleted the keybase branch September 2, 2018 10:25

Avaq mentioned this pull request May 2, 2020

keybase,kbfs,keybase-gui: 5.3.1 -> 5.4.2 #86185

Merged

10 tasks

		@@ -1,8 +1,8 @@
		{ stdenv, buildGoPackage, fetchFromGitHub }:
		{ stdenv, lib, buildGoPackage, fetchFromGitHub, darwin.apple_sdk.frameworks.AVFoundation ? null }:

keybase: 2.1.0 -> 2.5.0 #44698

keybase: 2.1.0 -> 2.5.0 #44698

Conversation

colemickens commented Aug 8, 2018

Motivation for this change

Things done

xeji commented Aug 8, 2018

GrahamcOfBorg commented Aug 8, 2018

GrahamcOfBorg commented Aug 8, 2018

xeji commented Aug 8, 2018

colemickens commented Aug 8, 2018

GrahamcOfBorg commented Aug 8, 2018

jonafato commented Aug 9, 2018

colemickens commented Aug 9, 2018 • edited Loading

xeji commented Aug 9, 2018

GrahamcOfBorg commented Aug 9, 2018

GrahamcOfBorg commented Aug 9, 2018

GrahamcOfBorg commented Aug 9, 2018

colemickens commented Aug 9, 2018

xeji commented Aug 9, 2018 • edited Loading

xeji commented Aug 9, 2018

colemickens commented Aug 19, 2018

infinisil commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

infinisil Aug 19, 2018

Choose a reason for hiding this comment

colemickens commented Aug 22, 2018

xeji commented Aug 22, 2018

GrahamcOfBorg commented Aug 22, 2018

GrahamcOfBorg commented Aug 22, 2018

GrahamcOfBorg commented Aug 22, 2018

xeji commented Aug 22, 2018

colemickens commented Aug 22, 2018 • edited Loading

colemickens commented Aug 22, 2018

xeji commented Aug 22, 2018

GrahamcOfBorg commented Aug 22, 2018

GrahamcOfBorg commented Aug 22, 2018

GrahamcOfBorg commented Aug 22, 2018

xeji commented Aug 22, 2018

jonafato commented Aug 22, 2018

colemickens commented Aug 22, 2018

xeji commented Aug 22, 2018

GrahamcOfBorg commented Aug 22, 2018

GrahamcOfBorg commented Aug 22, 2018

GrahamcOfBorg commented Aug 22, 2018

xeji commented Aug 22, 2018

colemickens commented Aug 22, 2018

colemickens commented Aug 22, 2018

xeji commented Aug 22, 2018

GrahamcOfBorg commented Aug 22, 2018

GrahamcOfBorg commented Aug 22, 2018

GrahamcOfBorg commented Aug 22, 2018

colemickens commented Aug 9, 2018 •

edited

Loading

xeji commented Aug 9, 2018 •

edited

Loading

colemickens commented Aug 22, 2018 •

edited

Loading