Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.webkitgtk: 2.20.3 -> 2.20.4 #44678

Merged
merged 1 commit into from Aug 8, 2018
Merged

gnome3.webkitgtk: 2.20.3 -> 2.20.4 #44678

merged 1 commit into from Aug 8, 2018

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Aug 8, 2018

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/webkitgtk/versions.

meta.description for gnome3.webkitgtk is: '"Web content rendering engine, GTK+ port"'.

Checks done (click to expand)
Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:

cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:

git fetch r-ryantm && git checkout ba8d69ccec0f04a641dee1e7619af4be31ddfc8f && nix-shell --pure -I nixpkgs=. -p gnome3.webkitgtk

@hedning
Copy link
Contributor

hedning commented Aug 8, 2018

The postConfigure can be removed now, 2.20.4 fixed the issue: https://webkitgtk.org/2018/08/06/webkitgtk2.20.4-released.html

cc @ryantm is it easy to make small mods to these PRs, or should I create a new one?

@jtojnar
gnome3.webkitgtk: 2.20.3 -> 2.20.4
5f4bf57 
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/webkitgtk/versions.

Also removed no longer necessary postConfigure hook.

Signed-off-by: Jan Tojnar <jtojnar@gmail.com>
@jtojnar
Copy link
Contributor

jtojnar commented Aug 8, 2018

Done.

jtojnar
jtojnar approved these changes Aug 8, 2018
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with epiphany, works fine.

@jtojnar jtojnar merged commit bfa0132 into NixOS:master Aug 8, 2018
@r-ryantm r-ryantm deleted the auto-update/webkitgtk branch August 8, 2018 13:12
@ryantm
Copy link
Member

ryantm commented Aug 8, 2018

@hedning nixpkgs contributors can add on to @r-ryantm branches without any other permissions. Otherwise, you can make a PR against @r-ryantm's fork, or put a patch here in the PR comments and someone may apply it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @hedning @jtojnar @ryantm @GrahamcOfBorg