Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim_configurable: Add wrapGAppsHook for GTK 3 #44645

Merged
merged 1 commit into from Aug 9, 2018
Merged

vim_configurable: Add wrapGAppsHook for GTK 3 #44645

merged 1 commit into from Aug 9, 2018

Conversation

8573
Copy link
Contributor

@8573 8573 commented Aug 7, 2018

As suggested by @jtojnar in GitHub issue #44580, this patch adds the
package wrapGAppsHook to the dependencies (specifically, the
nativeBuildInputs) of vim_configurable, when vim_configurable is
built against GTK 3.

Motivation for this change

This change prevents GVim from crashing if one tries to use its
file-choosing dialog, and fixes a warning that otherwise might be
emitted if one tries to use its find/replace dialog.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@8573
vim_configurable: Add wrapGAppsHook for GTK 3
a7d7d07 
As suggested by @jtojnar in GitHub issue NixOS#44580, this patch adds the
package `wrapGAppsHook` to the dependencies (specifically, the
`nativeBuildInputs`) of `vim_configurable`, when `vim_configurable` is
built against GTK 3.

This change prevents GVim from crashing if one tries to use its
file-choosing dialog, and fixes a warning that otherwise might be
emitted if one tries to use its find/replace dialog.
@xeji
Copy link
Contributor

xeji commented Aug 9, 2018

@GrahamcOfBorg build vim_configurable

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vim_configurable

Partial log (click to expand)

/nix/store/yv29f5flkxv59lsmq5n5x8jl8xskv5lf-vim_configurable-8.1.0146/bin/.gvimtutor-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
head: error writing 'standard output': Broken pipe
/nix/store/yv29f5flkxv59lsmq5n5x8jl8xskv5lf-vim_configurable-8.1.0146/share/vim/vim81/macros/less.sh: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/yv29f5flkxv59lsmq5n5x8jl8xskv5lf-vim_configurable-8.1.0146/share/vim/vim81/tools/demoserver.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/9qjc0d5557h3dkpsvfq98b2k96lnb6pw-python-2.7.15/bin/python"
basename: invalid option -- 'w'
Try 'basename --help' for more information.
/nix/store/yv29f5flkxv59lsmq5n5x8jl8xskv5lf-vim_configurable-8.1.0146/share/vim/vim81/tools/vimm: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/yv29f5flkxv59lsmq5n5x8jl8xskv5lf-vim_configurable-8.1.0146/share/vim/vim81/tools/vimspell.sh: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/yv29f5flkxv59lsmq5n5x8jl8xskv5lf-vim_configurable-8.1.0146/share/vim/vim81/tools/ref: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/yv29f5flkxv59lsmq5n5x8jl8xskv5lf-vim_configurable-8.1.0146...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: vim_configurable

Partial log (click to expand)

'+fp' is not a recognized feature for this target (ignoring feature)
'+fp' is not a recognized feature for this target (ignoring feature)
'+fp' is not a recognized feature for this target (ignoring feature)
'+fp' is not a recognized feature for this target (ignoring feature)
building of '/nix/store/v7p50067w7hszwbd1xgqidli3svf87i3-rustc-1.27.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/g5r7q5mny7qs68pk7m7qf7mnb8k97ky7-cargo-1.27.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pnwbb486mxr06pmf6idrl44cahy2lqzg-librsvg-2.42.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/bjyl4428ib1lm3ahfsw84jz9zpp99jmj-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0flg7dk0jfk085l1swdfadj82i7q8051-vim_configurable-8.1.0146.drv': 1 dependencies couldn't be built
error: build of '/nix/store/0flg7dk0jfk085l1swdfadj82i7q8051-vim_configurable-8.1.0146.drv' failed

@xeji xeji merged commit 6b486cf into NixOS:master Aug 9, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: vim_configurable

Partial log (click to expand)

In file included from /nix/store/6w9yw7gqbfv5jd7r252k1r40wn3c9qsm-apple-framework-AppKit/Library/Frameworks/AppKit.framework/Headers/AppKit.h:203:
/nix/store/6w9yw7gqbfv5jd7r252k1r40wn3c9qsm-apple-framework-AppKit/Library/Frameworks/AppKit.framework/Headers/NSPathComponentCell.h:42:27: warning: 'copy' attribute on property 'image' does not match the property inherited from 'NSCell' [-Wproperty-attribute-mismatch]
@property (copy) NSImage *image;
                          ^
6 warnings and 11 errors generated.
make[1]: *** [Makefile:3260: objects/os_macosx.o] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-vim_configurable-8.1.0146.drv-0/source/src'
make: *** [Makefile:29: first] Error 2
builder for '/nix/store/zblwf48z9l0pvdkh5blxmr8h6bx0a4j7-vim_configurable-8.1.0146.drv' failed with exit code 2
error: build of '/nix/store/zblwf48z9l0pvdkh5blxmr8h6bx0a4j7-vim_configurable-8.1.0146.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@8573 @xeji @GrahamcOfBorg @jtojnar