Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output fetchSubmodules setting in src directive #371

Merged
merged 4 commits into from Aug 17, 2018

Conversation

kquick
Copy link
Contributor

@kquick kquick commented Aug 15, 2018

This was overlooked in my previous (accepted) patch which adds the --dont-fetch-submodules command-line flag: the generated nix specification for src should reflect the setting of that flag so that the corresponding fetchgit operation behaves similarly. This has no effect for src directives that do not use fetchgit.

@kquick
Copy link
Contributor Author

kquick commented Aug 16, 2018

@basvandijk: sorry, but I missed this functionality in the previous patch which added the --dont-fetch-submodules. I've tested the results, and it all should be working now with the addition of this PR.

@peti peti merged commit 1109639 into NixOS:master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants