Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxml2: fix CVE-2018-14567 & CVE-2018-14404 #45086

Merged
merged 1 commit into from Aug 16, 2018
Merged

libxml2: fix CVE-2018-14567 & CVE-2018-14404 #45086

merged 1 commit into from Aug 16, 2018

Conversation

andir
Copy link
Member

@andir andir commented Aug 15, 2018

Motivation for this change

Fixes CVE-2018-14567 & CVE-2018-14404

Since the already added patch for CVE-2018-9251 also affects
CVE-2018-14567 I renamed the applied patch accordingly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir
libxml2: fix CVE-2018-14567 & CVE-2018-14404
06e7a48 
Since the already added patch for CVE-2018-9251 also affects
CVE-2018-14567 I renamed the applied patch accordingly.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libxml2

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/wzypyc17jmsd7yanp0a8j44pncdkaxj6-libxml2-2.9.8-py/lib
patching script interpreter paths in /nix/store/wzypyc17jmsd7yanp0a8j44pncdkaxj6-libxml2-2.9.8-py
checking for references to /build in /nix/store/wzypyc17jmsd7yanp0a8j44pncdkaxj6-libxml2-2.9.8-py...
Moving /nix/store/96cw1a2jjxdd7jgzwq4p81qj6xhkj4wk-libxml2-2.9.8-bin/bin/xml2-config to /nix/store/mb9pccqkzz86h650lvwgqdr7sw22bj03-libxml2-2.9.8-dev/bin/xml2-config
rmdir: failed to remove '/nix/store/96cw1a2jjxdd7jgzwq4p81qj6xhkj4wk-libxml2-2.9.8-bin/bin': Directory not empty
Moving /nix/store/c0d86q06kl7riv3a0m1yyzbgd2pyvypv-libxml2-2.9.8/lib/xml2Conf.sh to /nix/store/mb9pccqkzz86h650lvwgqdr7sw22bj03-libxml2-2.9.8-dev/lib/xml2Conf.sh
rmdir: failed to remove '/nix/store/c0d86q06kl7riv3a0m1yyzbgd2pyvypv-libxml2-2.9.8/lib': Directory not empty
Moving /nix/store/lgcrghjjpksj52zjqfmkhzvlhcialr5n-libxml2-2.9.8-man/share/man/man1 to /nix/store/96cw1a2jjxdd7jgzwq4p81qj6xhkj4wk-libxml2-2.9.8-bin/share/man/man1
rmdir: failed to remove '/nix/store/lgcrghjjpksj52zjqfmkhzvlhcialr5n-libxml2-2.9.8-man/share/man': Directory not empty
/nix/store/96cw1a2jjxdd7jgzwq4p81qj6xhkj4wk-libxml2-2.9.8-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libxml2

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/p0g8sah8mwpxrrvficflkg7r130myhzq-libxml2-2.9.8-py/lib
patching script interpreter paths in /nix/store/p0g8sah8mwpxrrvficflkg7r130myhzq-libxml2-2.9.8-py
checking for references to /build in /nix/store/p0g8sah8mwpxrrvficflkg7r130myhzq-libxml2-2.9.8-py...
Moving /nix/store/20w9svy9h6i0riyhxiw607v7gb4y3zhc-libxml2-2.9.8-bin/bin/xml2-config to /nix/store/8dk3ckjcx4xjvs52wzpi6r0ym51v3pyy-libxml2-2.9.8-dev/bin/xml2-config
rmdir: failed to remove '/nix/store/20w9svy9h6i0riyhxiw607v7gb4y3zhc-libxml2-2.9.8-bin/bin': Directory not empty
Moving /nix/store/2nn12kbsjvh36lcpzxd2wg1sqxwy1mn9-libxml2-2.9.8/lib/xml2Conf.sh to /nix/store/8dk3ckjcx4xjvs52wzpi6r0ym51v3pyy-libxml2-2.9.8-dev/lib/xml2Conf.sh
rmdir: failed to remove '/nix/store/2nn12kbsjvh36lcpzxd2wg1sqxwy1mn9-libxml2-2.9.8/lib': Directory not empty
Moving /nix/store/pb2ds9k600x7p0n02gn20dcgg767pj94-libxml2-2.9.8-man/share/man/man1 to /nix/store/20w9svy9h6i0riyhxiw607v7gb4y3zhc-libxml2-2.9.8-bin/share/man/man1
rmdir: failed to remove '/nix/store/pb2ds9k600x7p0n02gn20dcgg767pj94-libxml2-2.9.8-man/share/man': Directory not empty
/nix/store/20w9svy9h6i0riyhxiw607v7gb4y3zhc-libxml2-2.9.8-bin

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: libxml2

Partial log (click to expand)

cannot build derivation '/nix/store/gm6nzb9vdfglbnd4p3snjc2dhfz53ll4-libtool-2.4.6.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/nwz4dz77qd2jk85yijz54ss9350kg390-hook.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/dz3pb9ip5rwqvxi30m3y1lqgj770qhj8-flex-2.6.4.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/xxm8lzyfrwh4hc3vcqvsvb2qgq1hv99f-bootstrap_cmds-dev-tools-7.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/z7zysz0vihqp0l9dypycyvdz7v30p1xc-xnu-osx-10.11.6.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/xb7vkmmvqbpz49h1dws0cmszxqxgy161-IOKit-osx-10.11.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/5x9ib5wpbn7qzvdr83wpf3ma4q9gv2gw-configd-osx-10.8.5.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/n2l3077g9qbm9l635b9akx2qkdjzv3n0-python-2.7.15.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/70qv038hgx3v7vhig9z7wpwd95xknx4m-libxml2-2.9.8.drv': 5 dependencies couldn't be built
error: build of '/nix/store/70qv038hgx3v7vhig9z7wpwd95xknx4m-libxml2-2.9.8.drv' failed

@andir andir merged commit 9632b17 into NixOS:staging Aug 16, 2018
@andir andir deleted the staging/libxml2 branch August 16, 2018 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @GrahamcOfBorg