Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.03] libxml2: fix CVE-2018-14567 & CVE-2018-14404 & CVE-2018-9251 #45087

Merged
merged 1 commit into from Aug 15, 2018
Merged

[18.03] libxml2: fix CVE-2018-14567 & CVE-2018-14404 & CVE-2018-9251 #45087

merged 1 commit into from Aug 15, 2018

Conversation

andir
Copy link
Member

@andir andir commented Aug 15, 2018

Motivation for this change

backport of 06e7a48

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Aug 15, 2018

@GrahamcOfBorg build libxml2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libxml2

Partial log (click to expand)

strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rlpri2hv9lbpmb28qkl6im4yv3si5gvf-libxml2-2.9.7-py/lib
patching script interpreter paths in /nix/store/rlpri2hv9lbpmb28qkl6im4yv3si5gvf-libxml2-2.9.7-py
checking for references to /build in /nix/store/rlpri2hv9lbpmb28qkl6im4yv3si5gvf-libxml2-2.9.7-py...
Moving /nix/store/vywwsqjz3gpdrqc3hpilw8s043xzmmwc-libxml2-2.9.7-bin/bin/xml2-config to /nix/store/s9gimgx6aqkj4y4hah0b9ggvyc4iabhr-libxml2-2.9.7-dev/bin/xml2-config
rmdir: failed to remove '/nix/store/vywwsqjz3gpdrqc3hpilw8s043xzmmwc-libxml2-2.9.7-bin/bin': Directory not empty
Moving /nix/store/mzpcmn5hggx412gq8zfbwrcbnx8p9rdy-libxml2-2.9.7/lib/xml2Conf.sh to /nix/store/s9gimgx6aqkj4y4hah0b9ggvyc4iabhr-libxml2-2.9.7-dev/lib/xml2Conf.sh
rmdir: failed to remove '/nix/store/mzpcmn5hggx412gq8zfbwrcbnx8p9rdy-libxml2-2.9.7/lib': Directory not empty
Moving /nix/store/sq0d65ld1j8x23clcgg0hq3mbda597lk-libxml2-2.9.7-man/share/man/man1 to /nix/store/vywwsqjz3gpdrqc3hpilw8s043xzmmwc-libxml2-2.9.7-bin/share/man/man1
rmdir: failed to remove '/nix/store/sq0d65ld1j8x23clcgg0hq3mbda597lk-libxml2-2.9.7-man/share/man': Directory not empty

vcunat
vcunat approved these changes Aug 15, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@vcunat vcunat merged commit bf3a543 into NixOS:staging-18.03 Aug 15, 2018
@andir andir deleted the staging-18.03/libxml2 branch August 15, 2018 21:17
@vcunat
Copy link
Member

vcunat commented Aug 15, 2018

The changes clearly seem platform-neutral.

@vcunat
Copy link
Member

vcunat commented Aug 15, 2018 •
edited

@andir: more mass rebuilds coming now to 18.03, or can Hydra start rebuilding?

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libxml2

Partial log (click to expand)

strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rlpri2hv9lbpmb28qkl6im4yv3si5gvf-libxml2-2.9.7-py/lib
patching script interpreter paths in /nix/store/rlpri2hv9lbpmb28qkl6im4yv3si5gvf-libxml2-2.9.7-py
checking for references to /build in /nix/store/rlpri2hv9lbpmb28qkl6im4yv3si5gvf-libxml2-2.9.7-py...
Moving /nix/store/vywwsqjz3gpdrqc3hpilw8s043xzmmwc-libxml2-2.9.7-bin/bin/xml2-config to /nix/store/s9gimgx6aqkj4y4hah0b9ggvyc4iabhr-libxml2-2.9.7-dev/bin/xml2-config
rmdir: failed to remove '/nix/store/vywwsqjz3gpdrqc3hpilw8s043xzmmwc-libxml2-2.9.7-bin/bin': Directory not empty
Moving /nix/store/mzpcmn5hggx412gq8zfbwrcbnx8p9rdy-libxml2-2.9.7/lib/xml2Conf.sh to /nix/store/s9gimgx6aqkj4y4hah0b9ggvyc4iabhr-libxml2-2.9.7-dev/lib/xml2Conf.sh
rmdir: failed to remove '/nix/store/mzpcmn5hggx412gq8zfbwrcbnx8p9rdy-libxml2-2.9.7/lib': Directory not empty
Moving /nix/store/sq0d65ld1j8x23clcgg0hq3mbda597lk-libxml2-2.9.7-man/share/man/man1 to /nix/store/vywwsqjz3gpdrqc3hpilw8s043xzmmwc-libxml2-2.9.7-bin/share/man/man1
rmdir: failed to remove '/nix/store/sq0d65ld1j8x23clcgg0hq3mbda597lk-libxml2-2.9.7-man/share/man': Directory not empty

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libxml2

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/4wvxwfkhp1nrvq8jhl5pdd49xzvmwlna-libxml2-2.9.7-py/lib
patching script interpreter paths in /nix/store/4wvxwfkhp1nrvq8jhl5pdd49xzvmwlna-libxml2-2.9.7-py
checking for references to /build in /nix/store/4wvxwfkhp1nrvq8jhl5pdd49xzvmwlna-libxml2-2.9.7-py...
Moving /nix/store/njmdbayzviqglax2hlxhfnfdr065ggi2-libxml2-2.9.7-bin/bin/xml2-config to /nix/store/yl5pnzjh8naajr7z99jq75msnmg26b3g-libxml2-2.9.7-dev/bin/xml2-config
rmdir: failed to remove '/nix/store/njmdbayzviqglax2hlxhfnfdr065ggi2-libxml2-2.9.7-bin/bin': Directory not empty
Moving /nix/store/k1zlikjjd5cbgdrx04fighq03lb0jha8-libxml2-2.9.7/lib/xml2Conf.sh to /nix/store/yl5pnzjh8naajr7z99jq75msnmg26b3g-libxml2-2.9.7-dev/lib/xml2Conf.sh
rmdir: failed to remove '/nix/store/k1zlikjjd5cbgdrx04fighq03lb0jha8-libxml2-2.9.7/lib': Directory not empty
Moving /nix/store/iyacj90j8akwnxbrxv9yil1ryw9am3ba-libxml2-2.9.7-man/share/man/man1 to /nix/store/njmdbayzviqglax2hlxhfnfdr065ggi2-libxml2-2.9.7-bin/share/man/man1
rmdir: failed to remove '/nix/store/iyacj90j8akwnxbrxv9yil1ryw9am3ba-libxml2-2.9.7-man/share/man': Directory not empty
/nix/store/njmdbayzviqglax2hlxhfnfdr065ggi2-libxml2-2.9.7-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libxml2

Partial log (click to expand)

these derivations will be built:
  /nix/store/rmnk0xglasylx4irliar9shhds4myg8i-libxml2-2.9.7.drv
waiting for locks or build slots...
/nix/store/njmdbayzviqglax2hlxhfnfdr065ggi2-libxml2-2.9.7-bin

@andir
Copy link
Member Author

andir commented Aug 15, 2018

@vcunat My time for today is almost over. There are no more mass-rebuilds on my list for today :)

Thanks for picking them up!

@vcunat
Copy link
Member

vcunat commented Aug 15, 2018

Right, today ends in half an hour in my timezone (and yours as well, I think).

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: libxml2

Partial log (click to expand)

cannot build derivation '/nix/store/q36b107h0956d82arshlddjv29qi3y7l-flex-2.6.4.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/0adi003cdg6pwk6qgpqf3w7gikh38m25-CF-osx-10.10.5.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/qshxipi8y3h1248qdk5al26bc57zbhvd-bootstrap_cmds-dev-tools-7.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/k139s3nmp7qakwr3bq1nvdz9hbwk0d7j-python-2.7.15.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/254444qf23aa26sb1h7myfl4kjdzy7x7-xnu-osx-10.11.6.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/l0wnmbhzdbcac6m0aq7415h7l0xgdp59-IOKit-osx-10.11.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/4051r8yv9vlck076nrnf90s6z5zz06v3-configd-osx-10.8.5.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/lz9zs2py1vwwaah14s0zpys3iik7mclg-python-2.7.15.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/x2nh0x7sw12dr0p4fv9vhjxqsi2ngd03-libxml2-2.9.7.drv': 7 dependencies couldn't be built
error: build of '/nix/store/x2nh0x7sw12dr0p4fv9vhjxqsi2ngd03-libxml2-2.9.7.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: libxml2

Partial log (click to expand)

cannot build derivation '/nix/store/q36b107h0956d82arshlddjv29qi3y7l-flex-2.6.4.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/0adi003cdg6pwk6qgpqf3w7gikh38m25-CF-osx-10.10.5.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/qshxipi8y3h1248qdk5al26bc57zbhvd-bootstrap_cmds-dev-tools-7.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/k139s3nmp7qakwr3bq1nvdz9hbwk0d7j-python-2.7.15.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/254444qf23aa26sb1h7myfl4kjdzy7x7-xnu-osx-10.11.6.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/l0wnmbhzdbcac6m0aq7415h7l0xgdp59-IOKit-osx-10.11.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4051r8yv9vlck076nrnf90s6z5zz06v3-configd-osx-10.8.5.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/lz9zs2py1vwwaah14s0zpys3iik7mclg-python-2.7.15.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/x2nh0x7sw12dr0p4fv9vhjxqsi2ngd03-libxml2-2.9.7.drv': 3 dependencies couldn't be built
error: build of '/nix/store/x2nh0x7sw12dr0p4fv9vhjxqsi2ngd03-libxml2-2.9.7.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @vcunat @GrahamcOfBorg