Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: 4.7.6 -> 4.7.9 #45090

Merged
merged 1 commit into from Aug 16, 2018
Merged

samba: 4.7.6 -> 4.7.9 #45090

merged 1 commit into from Aug 16, 2018

Conversation

andir
Copy link
Member

@andir andir commented Aug 15, 2018

Motivation for this change

Version 4.7.9 is a security release. The versions 4.7.7 & 4.7.8 contain
numerous bug fixes.

This fixes a couple of security related issues:

Changelogs for the version upgrades can be found below.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: samba

Partial log (click to expand)

strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hgda0kd93gy84jl7n0dljznlx6z2yv3k-samba-4.7.9-dev/lib
patching script interpreter paths in /nix/store/hgda0kd93gy84jl7n0dljznlx6z2yv3k-samba-4.7.9-dev
checking for references to /build in /nix/store/hgda0kd93gy84jl7n0dljznlx6z2yv3k-samba-4.7.9-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/lm796jbmv3jssanvvd70s5ymfnsi8brs-samba-4.7.9-man
gzipping man pages under /nix/store/lm796jbmv3jssanvvd70s5ymfnsi8brs-samba-4.7.9-man/share/man/
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/lm796jbmv3jssanvvd70s5ymfnsi8brs-samba-4.7.9-man
checking for references to /build in /nix/store/lm796jbmv3jssanvvd70s5ymfnsi8brs-samba-4.7.9-man...
/nix/store/16wm5zh5chzcrn6h5vkv1zgzr74zz5sn-samba-4.7.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: samba

Partial log (click to expand)

strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bvycbff25k3w1z0yvazripqi3r9ndqqm-samba-4.7.9-dev/lib
patching script interpreter paths in /nix/store/bvycbff25k3w1z0yvazripqi3r9ndqqm-samba-4.7.9-dev
checking for references to /build in /nix/store/bvycbff25k3w1z0yvazripqi3r9ndqqm-samba-4.7.9-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/brxngszzgdiqg9rw0ysjg35p94lj4mqh-samba-4.7.9-man
gzipping man pages under /nix/store/brxngszzgdiqg9rw0ysjg35p94lj4mqh-samba-4.7.9-man/share/man/
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/brxngszzgdiqg9rw0ysjg35p94lj4mqh-samba-4.7.9-man
checking for references to /build in /nix/store/brxngszzgdiqg9rw0ysjg35p94lj4mqh-samba-4.7.9-man...
/nix/store/gbqaf838rh6hak40mj2gmgfm4pii6384-samba-4.7.9

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: samba

Partial log (click to expand)

/nix/store/54iz4dfqk0kziz9jdc7kr8w310rcz7q6-samba-4.7.9/bin/pidl: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/dh0p5jg7ympcljg6lq5k8fycbx8cd40k-perl-5.24.4/bin/perl"
/nix/store/54iz4dfqk0kziz9jdc7kr8w310rcz7q6-samba-4.7.9/bin/smbtar: interpreter directive changed from "/bin/sh" to "/nix/store/hp9yq2m1i066irvasv20zr2lmj54fk9h-bash-4.4-p23/bin/sh"
moving /nix/store/54iz4dfqk0kziz9jdc7kr8w310rcz7q6-samba-4.7.9/sbin/* to /nix/store/54iz4dfqk0kziz9jdc7kr8w310rcz7q6-samba-4.7.9/bin
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/sc94i740kbnlx9x5y44xav7y9709v3mq-samba-4.7.9-dev/lib
patching script interpreter paths in /nix/store/sc94i740kbnlx9x5y44xav7y9709v3mq-samba-4.7.9-dev
gzipping man pages under /nix/store/d55h1bxii1gac74b6gc55wj42z84cazc-samba-4.7.9-man/share/man/
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/d55h1bxii1gac74b6gc55wj42z84cazc-samba-4.7.9-man
/nix/store/54iz4dfqk0kziz9jdc7kr8w310rcz7q6-samba-4.7.9

@srhb
Copy link
Contributor

srhb commented Aug 16, 2018

@GrahamcOfBorg test samba

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.samba

Partial log (click to expand)

client: exit status 0
server: running command: sync
server: exit status 0
test script finished in 290.10s
cleaning up
killing client (pid 615)
killing server (pid 600)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/9yi243j8l584n05dy1f85hv63wj5slx1-vm-test-run-samba

@srhb
Copy link
Contributor

srhb commented Aug 16, 2018

Thanks!

@srhb srhb merged commit 7e32b40 into NixOS:master Aug 16, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.samba

Partial log (click to expand)

server: exit status 0
client: running command: sync
client: exit status 0
test script finished in 46.35s
cleaning up
killing server (pid 631)
killing client (pid 656)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/9ffy3k3j9hzzv40ks55gc5amwb99ffy2-vm-test-run-samba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @GrahamcOfBorg @srhb