Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: 4.7.6 -> 4.7.9 #45091

Merged
merged 1 commit into from Aug 16, 2018
Merged

samba: 4.7.6 -> 4.7.9 #45091

merged 1 commit into from Aug 16, 2018

Conversation

andir
Copy link
Member

@andir andir commented Aug 15, 2018

Version 4.7.9 is a security release. The versions 4.7.7 & 4.7.8 contain
numerous bug fixes.

This fixes a couple of security related issues:

Changelogs for the version upgrades can be found below.

(cherry picked from commit 67ea2c0)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: samba

Partial log (click to expand)

strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/am5pgwxd6cy3l6kf5ypq6yv0329sgz67-samba-4.7.9-dev/lib
patching script interpreter paths in /nix/store/am5pgwxd6cy3l6kf5ypq6yv0329sgz67-samba-4.7.9-dev
checking for references to /build in /nix/store/am5pgwxd6cy3l6kf5ypq6yv0329sgz67-samba-4.7.9-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/gd74ckgfvpsjlccdhm5id0qx7i6qqf4f-samba-4.7.9-man
gzipping man pages under /nix/store/gd74ckgfvpsjlccdhm5id0qx7i6qqf4f-samba-4.7.9-man/share/man/
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/gd74ckgfvpsjlccdhm5id0qx7i6qqf4f-samba-4.7.9-man
checking for references to /build in /nix/store/gd74ckgfvpsjlccdhm5id0qx7i6qqf4f-samba-4.7.9-man...
/nix/store/54937n3s2b9xpgakyg7c7a49i4njydvy-samba-4.7.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: samba

Partial log (click to expand)

strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/656vxgzazgjw1b6k3jkgc1k3aqhxijmj-samba-4.7.9-dev/lib
patching script interpreter paths in /nix/store/656vxgzazgjw1b6k3jkgc1k3aqhxijmj-samba-4.7.9-dev
checking for references to /build in /nix/store/656vxgzazgjw1b6k3jkgc1k3aqhxijmj-samba-4.7.9-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/9zn6a498638hdadx55wnjlqn8y4j3276-samba-4.7.9-man
gzipping man pages under /nix/store/9zn6a498638hdadx55wnjlqn8y4j3276-samba-4.7.9-man/share/man/
strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/9zn6a498638hdadx55wnjlqn8y4j3276-samba-4.7.9-man
checking for references to /build in /nix/store/9zn6a498638hdadx55wnjlqn8y4j3276-samba-4.7.9-man...
/nix/store/cr2f07vhj7ky543m093ii849ghxazss6-samba-4.7.9

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: samba

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@srhb
Copy link
Contributor

srhb commented Aug 16, 2018

@GrahamcOfBorg test samba

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.samba

Partial log (click to expand)

server: exit status 0
client: running command: sync
client: exit status 0
test script finished in 18.63s
cleaning up
killing server (pid 596)
killing client (pid 613)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/932wlwkhhv1fclm1hcqr820s0fjv22xc-vm-test-run-samba

@srhb srhb merged commit c1ef96e into NixOS:release-18.03 Aug 16, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.samba

Partial log (click to expand)

client: exit status 0
server: running command: sync
server: exit status 0
test script finished in 49.42s
cleaning up
killing client (pid 647)
killing server (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/czsbjdhgrxgkwxal728kgx3liblaplfk-vm-test-run-samba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @GrahamcOfBorg @srhb