Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kubernetes: fix kubelet cgroup stats #44264

Merged
merged 1 commit into from Aug 1, 2018
Merged

nixos/kubernetes: fix kubelet cgroup stats #44264

merged 1 commit into from Aug 1, 2018

Conversation

eonpatapon
Copy link
Contributor

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Closes #44263

See also kubernetes/kubernetes#56850

@Mic92 Mic92 merged commit 69a94a0 into NixOS:master Aug 1, 2018
@Mic92
Copy link
Member

Mic92 commented Aug 1, 2018

Is a backport required here?

@eonpatapon
Copy link
Contributor Author

Thanks

Ideally I would like to have this in 18.03

@Mic92
Copy link
Member

Mic92 commented Aug 1, 2018

[detached HEAD 1596c81] nixos/kubernetes: fix kubelet cgroup stats
Author: Jean-Philippe Braun eon@patapon.info
Date: Tue Jul 31 15:45:37 2018 +0200
1 file changed, 2 insertions(+)

@eonpatapon eonpatapon deleted the kubelet-cgroup-stats branch September 2, 2018 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eonpatapon @Mic92 @GrahamcOfBorg