Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

photon: init at 1.0.7 #44269

Merged
merged 1 commit into from Aug 2, 2018
Merged

photon: init at 1.0.7 #44269

merged 1 commit into from Aug 2, 2018

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented Jul 31, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

@GrahamcOfBorg build photon

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: photon

Partial log (click to expand)

updateAutotoolsGnuConfigScriptsPhase
configuring
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/177l6bj99qk8k5980fc5xrj4n76xqzg9-photon-1.0.7
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/177l6bj99qk8k5980fc5xrj4n76xqzg9-photon-1.0.7/bin
patching script interpreter paths in /nix/store/177l6bj99qk8k5980fc5xrj4n76xqzg9-photon-1.0.7
checking for references to /build in /nix/store/177l6bj99qk8k5980fc5xrj4n76xqzg9-photon-1.0.7...
/nix/store/177l6bj99qk8k5980fc5xrj4n76xqzg9-photon-1.0.7

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: photon

Partial log (click to expand)

source root is Photon-1.0.7
setting SOURCE_DATE_EPOCH to timestamp 1532793646 of file Photon-1.0.7/requirements.txt
patching sources
configuring
installing
post-installation fixup
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/nq8bwwkhdlzr6rb27vzjrpp0lwcz55yr-photon-1.0.7/bin
patching script interpreter paths in /nix/store/nq8bwwkhdlzr6rb27vzjrpp0lwcz55yr-photon-1.0.7
/nix/store/nq8bwwkhdlzr6rb27vzjrpp0lwcz55yr-photon-1.0.7

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: photon

Partial log (click to expand)

patching sources
configuring
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rbcakz87lxldn5a8blxvhbp2k7fx93xa-photon-1.0.7
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rbcakz87lxldn5a8blxvhbp2k7fx93xa-photon-1.0.7/bin
patching script interpreter paths in /nix/store/rbcakz87lxldn5a8blxvhbp2k7fx93xa-photon-1.0.7
checking for references to /build in /nix/store/rbcakz87lxldn5a8blxvhbp2k7fx93xa-photon-1.0.7...
/nix/store/rbcakz87lxldn5a8blxvhbp2k7fx93xa-photon-1.0.7

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

After installing this with nix-env, it seems to look for user-agents.txt in the wrong place

[~/nixpkgs]$ photon -u http://nixos.org
      ____  __          __            
     / __ \/ /_  ____  / /_____  ____ 
    / /_/ / __ \/ __ \/ __/ __ \/ __ \
   / ____/ / / / /_/ / /_/ /_/ / / / /
  /_/   /_/ /_/\____/\__/\____/_/ /_/ 

Traceback (most recent call last):
  File "/nix/store/rbcakz87lxldn5a8blxvhbp2k7fx93xa-photon-1.0.7/share/photon/photon.py", line 188, in <module>
    with open(os.getcwd() + '/core/user-agents.txt', 'r') as uas:
IOError: [Errno 2] No such file or directory: '/home/me/nixpkgs/core/user-agents.txt'

@bignaux
Copy link
Contributor Author

bignaux commented Aug 1, 2018

i donno how to solve this. --run "cd $out/share/photon" is a bad idea since it runs in the nix-store so it can't save file. My previous iteration would work with --user-agent defined at command time.

@bignaux
Copy link
Contributor Author

bignaux commented Aug 2, 2018

finally i did a patch to avoid this conception problem around os.getcwd().

@xeji xeji merged commit 38e582c into NixOS:master Aug 2, 2018
@bignaux bignaux deleted the photon branch August 2, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bignaux @xeji @GrahamcOfBorg