Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpeg: 3.4.3 -> 3.4.4 (bugfix) #44267

Merged
merged 1 commit into from Aug 1, 2018
Merged

ffmpeg: 3.4.3 -> 3.4.4 (bugfix) #44267

merged 1 commit into from Aug 1, 2018

Conversation

mat8913
Copy link
Contributor

@mat8913 mat8913 commented Jul 31, 2018 •
edited

Motivation for this change

Fixes #44256

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mat8913
Copy link
Contributor Author

mat8913 commented Jul 31, 2018

Oh oops, I just realized ffmpeg-full is 4.0.1 on master. This commit only changes ffmpeg then, not ffmpeg-full.

@mat8913 mat8913 changed the title ffmpeg{,-full}: 3.4.3 -> 3.4.4 (bugfix) ffmpeg: 3.4.3 -> 3.4.4 (bugfix) Jul 31, 2018
@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

@GrahamcOfBorg build ffmpeg

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ffmpeg

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/16iq25hh8wq96vm4w6mcn20c4pi2v4mw-ffmpeg-3.4.4-man
gzipping man pages under /nix/store/16iq25hh8wq96vm4w6mcn20c4pi2v4mw-ffmpeg-3.4.4-man/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/16iq25hh8wq96vm4w6mcn20c4pi2v4mw-ffmpeg-3.4.4-man
checking for references to /build in /nix/store/16iq25hh8wq96vm4w6mcn20c4pi2v4mw-ffmpeg-3.4.4-man...
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
Moving /nix/store/q9fpfyn4l4dx30mnl75ncacfh3gqh25n-ffmpeg-3.4.4/bin to /nix/store/n5spjhvyfcdyiwghpwsjzzyqlxmlgn3f-ffmpeg-3.4.4-bin/bin
rmdir: failed to remove '/nix/store/q9fpfyn4l4dx30mnl75ncacfh3gqh25n-ffmpeg-3.4.4': Directory not empty
Moving /nix/store/q9fpfyn4l4dx30mnl75ncacfh3gqh25n-ffmpeg-3.4.4/share/ffmpeg/examples to /nix/store/y014yrqcwh3yrxwbndqq2h84gqzy5l53-ffmpeg-3.4.4-doc/share/ffmpeg/examples
rmdir: failed to remove '/nix/store/q9fpfyn4l4dx30mnl75ncacfh3gqh25n-ffmpeg-3.4.4/share/ffmpeg': Directory not empty

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ffmpeg

Partial log (click to expand)

gzipping man pages under /nix/store/vlrn8jg0nm5fvmanngpds3gqdlh0d1ka-ffmpeg-3.4.4-man/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/vlrn8jg0nm5fvmanngpds3gqdlh0d1ka-ffmpeg-3.4.4-man
checking for references to /build in /nix/store/vlrn8jg0nm5fvmanngpds3gqdlh0d1ka-ffmpeg-3.4.4-man...
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
Moving /nix/store/6a37x08y7f7hmwzmr83q8fpbm6286yla-ffmpeg-3.4.4/bin to /nix/store/nrxhrzwlq41rc6ra580fh76xsy9szkzs-ffmpeg-3.4.4-bin/bin
rmdir: failed to remove '/nix/store/6a37x08y7f7hmwzmr83q8fpbm6286yla-ffmpeg-3.4.4': Directory not empty
Moving /nix/store/6a37x08y7f7hmwzmr83q8fpbm6286yla-ffmpeg-3.4.4/share/ffmpeg/examples to /nix/store/n997hrp7mby1xma84bnf5nbxx36ay844-ffmpeg-3.4.4-doc/share/ffmpeg/examples
rmdir: failed to remove '/nix/store/6a37x08y7f7hmwzmr83q8fpbm6286yla-ffmpeg-3.4.4/share/ffmpeg': Directory not empty
/nix/store/nrxhrzwlq41rc6ra580fh76xsy9szkzs-ffmpeg-3.4.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ffmpeg

Partial log (click to expand)

find: '/nix/store/6srmhkbb1my75hvj6h3fg6bpccyn6pb6-ffmpeg-3.4.4-doc': No such file or directory
find: '/nix/store/6srmhkbb1my75hvj6h3fg6bpccyn6pb6-ffmpeg-3.4.4-doc': No such file or directory
find: '/nix/store/6srmhkbb1my75hvj6h3fg6bpccyn6pb6-ffmpeg-3.4.4-doc': No such file or directory
find: '/nix/store/6srmhkbb1my75hvj6h3fg6bpccyn6pb6-ffmpeg-3.4.4-doc': No such file or directory
find: '/nix/store/6srmhkbb1my75hvj6h3fg6bpccyn6pb6-ffmpeg-3.4.4-doc': No such file or directory
Moving /nix/store/vhyvw249n8rjhpa41hczys6rd8xrmkch-ffmpeg-3.4.4/bin to /nix/store/a92hd519n9xyigyz2mwnmhr200p2774a-ffmpeg-3.4.4-bin/bin
rmdir: failed to remove '/nix/store/vhyvw249n8rjhpa41hczys6rd8xrmkch-ffmpeg-3.4.4': Directory not empty
Moving /nix/store/vhyvw249n8rjhpa41hczys6rd8xrmkch-ffmpeg-3.4.4/share/ffmpeg/examples to /nix/store/6srmhkbb1my75hvj6h3fg6bpccyn6pb6-ffmpeg-3.4.4-doc/share/ffmpeg/examples
rmdir: failed to remove '/nix/store/vhyvw249n8rjhpa41hczys6rd8xrmkch-ffmpeg-3.4.4/share/ffmpeg': Directory not empty
/nix/store/a92hd519n9xyigyz2mwnmhr200p2774a-ffmpeg-3.4.4-bin

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

@GrahamcOfBorg build mpv

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mpv

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hn0wcm02f1bvdzcqrzyhnwjs9a3ldp4c-mpv-0.29.0
shrinking /nix/store/hn0wcm02f1bvdzcqrzyhnwjs9a3ldp4c-mpv-0.29.0/bin/.mpv-wrapped
shrinking /nix/store/hn0wcm02f1bvdzcqrzyhnwjs9a3ldp4c-mpv-0.29.0/lib/libmpv.so.1.101.0
gzipping man pages under /nix/store/hn0wcm02f1bvdzcqrzyhnwjs9a3ldp4c-mpv-0.29.0/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hn0wcm02f1bvdzcqrzyhnwjs9a3ldp4c-mpv-0.29.0/lib  /nix/store/hn0wcm02f1bvdzcqrzyhnwjs9a3ldp4c-mpv-0.29.0/bin
patching script interpreter paths in /nix/store/hn0wcm02f1bvdzcqrzyhnwjs9a3ldp4c-mpv-0.29.0
checking for references to /build in /nix/store/hn0wcm02f1bvdzcqrzyhnwjs9a3ldp4c-mpv-0.29.0...
/nix/store/hn0wcm02f1bvdzcqrzyhnwjs9a3ldp4c-mpv-0.29.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mpv

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l7fz530hjkm51ig3d4nphacdp2y087w7-mpv-0.29.0
shrinking /nix/store/l7fz530hjkm51ig3d4nphacdp2y087w7-mpv-0.29.0/lib/libmpv.so.1.101.0
shrinking /nix/store/l7fz530hjkm51ig3d4nphacdp2y087w7-mpv-0.29.0/bin/.mpv-wrapped
gzipping man pages under /nix/store/l7fz530hjkm51ig3d4nphacdp2y087w7-mpv-0.29.0/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l7fz530hjkm51ig3d4nphacdp2y087w7-mpv-0.29.0/lib  /nix/store/l7fz530hjkm51ig3d4nphacdp2y087w7-mpv-0.29.0/bin
patching script interpreter paths in /nix/store/l7fz530hjkm51ig3d4nphacdp2y087w7-mpv-0.29.0
checking for references to /build in /nix/store/l7fz530hjkm51ig3d4nphacdp2y087w7-mpv-0.29.0...
/nix/store/l7fz530hjkm51ig3d4nphacdp2y087w7-mpv-0.29.0

@xeji xeji merged commit 4f505d7 into NixOS:master Aug 1, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: mpv

Partial log (click to expand)

[1/1] Compiling version.sh
[  2/418] Processing osdep/macOS_swift.o osdep/macOS_swift.h osdep/macOS_swift.swiftmodule: osdep/macOS_mpv_helper.swift video/out/cocoa-cb/events_view.swift video/out/cocoa-cb/video_layer.swift video/out/cocoa-cb/window.swift video/out/cocoa_cb_common.swift -> build/osdep/macOS_swift.o build/osdep/macOS_swift.h build/osdep/macOS_swift.swiftmodule
[  3/418] Compiling TOOLS/osxbundle/mpv.app/Contents/Resources/icon.icns
/bin/sh: []: command not found

Waf: Leaving directory `/private/tmp/nix-build-mpv-0.29.0.drv-0/source/build'
Build failed
 -> task in 'osdep/macOS_swift.o osdep/macOS_swift.h osdep/macOS_swift.swiftmodule' failed with exit status 127 (run with -v to display more information)
builder for '/nix/store/01ia26z1gcxx2h2h6vkkhcizg2s8qxc6-mpv-0.29.0.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/01ia26z1gcxx2h2h6vkkhcizg2s8qxc6-mpv-0.29.0.drv' failed

@mat8913 mat8913 deleted the ffmpeg344 branch August 3, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mpv segfaults when I try to take a screenshot
4 participants
@mat8913 @xeji @GrahamcOfBorg @Janik-Haag