Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fluent-logger: init at 0.9.3 (#44236) #44270

Merged
merged 1 commit into from Jul 31, 2018
Merged

pythonPackages.fluent-logger: init at 0.9.3 (#44236) #44270

merged 1 commit into from Jul 31, 2018

Conversation

ngortheone
Copy link
Contributor

Backport #44236 to release-18.03

@ngortheone ngortheone requested a review from FRidh as a code owner July 31, 2018 18:49
@copumpkin
Copy link
Member

Looks pretty harmless, thanks!

cc @dotlambda @FRidh

@copumpkin copumpkin merged commit 0d78855 into NixOS:release-18.03 Jul 31, 2018
adisbladis pushed a commit that referenced this pull request Aug 1, 2018
@makefu @adisbladis
pythonPackages.python-forecastio: init at 1.4.0
60fe648 
(cherry picked from commit ecac42b)

This fixes broken eval of 18.03 introduced in PR #44270
@adisbladis
Copy link
Member

adisbladis commented Aug 1, 2018 •
edited

This broke eval because it expected pythonPackages.python-forecastio to exist.

Fixed by backporting ecac42b as 60fe648.

I haven't actually tested the packages involved, but at least it evals.

@copumpkin
Copy link
Member

Sorry about that, I should've had borg check it

@samueldr samueldr mentioned this pull request Aug 1, 2018
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ngortheone @copumpkin @adisbladis @GrahamcOfBorg