Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix libgpg-error cross build on armv7 #44275

Merged
merged 1 commit into from Aug 3, 2018
Merged

fix libgpg-error cross build on armv7 #44275

merged 1 commit into from Aug 3, 2018

Conversation

georgewhewell
Copy link
Contributor

Motivation for this change

libgpg-error fails to cross build for armv7:

./gpg-error.h.in:476: error including `./syscfg/lock-obj-pub.linux-gnueabihf.h': No such file or directory

the change in this PR allows it to build.
please say if there is a better way to fix this!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jul 31, 2018

cc @dtzWill who added a similar work-around for musl.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.libgpgerror

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pkgsCross.armv7l-hf-multiplatform.libgpgerror

Partial log (click to expand)

armv7a-unknown-linux-gnueabihf-strip is /nix/store/2gl3my51rg60hdgbzspql1k79g3b8hmq-armv7a-unknown-linux-gnueabihf-binutils-2.30/bin/armv7a-unknown-linux-gnueabihf-strip
stripping (with command armv7a-unknown-linux-gnueabihf-strip and flags -S) in /nix/store/qhnv0bwj44xwmss2if6nms6vhlyhz8qh-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-dev/bin
patching script interpreter paths in /nix/store/qhnv0bwj44xwmss2if6nms6vhlyhz8qh-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-dev
/nix/store/qhnv0bwj44xwmss2if6nms6vhlyhz8qh-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-dev/bin/gpgrt-config: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
/nix/store/qhnv0bwj44xwmss2if6nms6vhlyhz8qh-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-dev/bin/gpg-error-config: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/qhnv0bwj44xwmss2if6nms6vhlyhz8qh-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/s0xrccfp525fspb3aa5aifgh0jyvh0s6-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-info
armv7a-unknown-linux-gnueabihf-strip is /nix/store/2gl3my51rg60hdgbzspql1k79g3b8hmq-armv7a-unknown-linux-gnueabihf-binutils-2.30/bin/armv7a-unknown-linux-gnueabihf-strip
patching script interpreter paths in /nix/store/s0xrccfp525fspb3aa5aifgh0jyvh0s6-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-info
checking for references to /build in /nix/store/s0xrccfp525fspb3aa5aifgh0jyvh0s6-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-info...

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: pkgsCross.armv7l-hf-multiplatform.libgpgerror

Partial log (click to expand)

post-installation fixup
patching script interpreter paths in /nix/store/qlmqrvqw4yl7g075fv336z98nwhn091a-armv7a-unknown-linux-gnueabihf-stage-static-gcc-debug-wrapper-7.3.0
building '/nix/store/yk7dh07cplir5z3cg77akci2ncacs2js-stdenv-darwin.drv'...
cannot build derivation '/nix/store/415xibxgi1mxgp37qfmrvd7va0kk8pcd-glibc-2.27-armv7a-unknown-linux-gnueabihf.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/a03d4ws1ln04h0qnvhmkylp92awc2hzl-armv7a-unknown-linux-gnueabihf-binutils-wrapper-2.30.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ahxnwxvz6iq3h1pwhb3ls1r4wdn1iw00-armv7a-unknown-linux-gnueabihf-stage-final-gcc-debug-7.3.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/jlhvxz6f3fli1kc3vr90sn4liwzz0wj3-armv7a-unknown-linux-gnueabihf-stage-final-gcc-debug-wrapper-7.3.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/g74wfvsdffhnngvsw8cr2bj6dnznplz1-stdenv-darwin.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0jbwiyk545har1ag75kvy1ks43fckgiy-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/0jbwiyk545har1ag75kvy1ks43fckgiy-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pkgsCross.armv7l-hf-multiplatform.libgpgerror

Partial log (click to expand)

stripping (with command armv7a-unknown-linux-gnueabihf-strip and flags -S) in /nix/store/c68z0qwdqq0zv7nkvydvhzbq09z5k4yx-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-dev/bin
patching script interpreter paths in /nix/store/c68z0qwdqq0zv7nkvydvhzbq09z5k4yx-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-dev
/nix/store/c68z0qwdqq0zv7nkvydvhzbq09z5k4yx-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-dev/bin/gpgrt-config: interpreter directive changed from "/bin/sh" to "/nix/store/6vqgi9d49smsbr2qxra52yhipg0yxf9f-bash-4.4-p23/bin/sh"
/nix/store/c68z0qwdqq0zv7nkvydvhzbq09z5k4yx-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-dev/bin/gpg-error-config: interpreter directive changed from "/bin/sh" to "/nix/store/6vqgi9d49smsbr2qxra52yhipg0yxf9f-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/c68z0qwdqq0zv7nkvydvhzbq09z5k4yx-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/8n4ds1h9ajgaacs48lv6glsg2k74r98y-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-info
armv7a-unknown-linux-gnueabihf-strip is /nix/store/2l8s7g3lpriblljxmqmwxd8q11v9nrjl-armv7a-unknown-linux-gnueabihf-binutils-2.30/bin/armv7a-unknown-linux-gnueabihf-strip
patching script interpreter paths in /nix/store/8n4ds1h9ajgaacs48lv6glsg2k74r98y-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-info
checking for references to /build in /nix/store/8n4ds1h9ajgaacs48lv6glsg2k74r98y-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf-info...
/nix/store/b8qkqdw2ham1dw104z6916i9a0vq9rgz-libgpg-error-1.28-armv7a-unknown-linux-gnueabihf

@Mic92 Mic92 merged commit 30b3f27 into NixOS:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@georgewhewell @Mic92 @matthewbauer @GrahamcOfBorg