Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memo: 0.4 -> 0.5 #44273

Merged
merged 1 commit into from Jul 31, 2018
Merged

memo: 0.4 -> 0.5 #44273

merged 1 commit into from Jul 31, 2018

Conversation

mrVanDalo
Copy link
Contributor

Motivation for this change

Version Bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jul 31, 2018

@GrahamcOfBorg build memo

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: memo

Partial log (click to expand)

building
no Makefile, doing nothing
installing
post-installation fixup
gzipping man pages under /nix/store/zfqq721bmqzdrhm0fcx2jxp45mym9rvr-memo-0.5/share/man/
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/zfqq721bmqzdrhm0fcx2jxp45mym9rvr-memo-0.5/bin
patching script interpreter paths in /nix/store/zfqq721bmqzdrhm0fcx2jxp45mym9rvr-memo-0.5
/nix/store/zfqq721bmqzdrhm0fcx2jxp45mym9rvr-memo-0.5/bin/memo: interpreter directive changed from "/bin/bash" to "/nix/store/qb76s7s3p6pnsi7082sjfc7rb64f3s6a-bash-4.4-p23/bin/bash"
/nix/store/zfqq721bmqzdrhm0fcx2jxp45mym9rvr-memo-0.5

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: memo

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: memo

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rd1jzz81fnlm518155xvaq3cka6wdf17-memo-0.5
gzipping man pages under /nix/store/rd1jzz81fnlm518155xvaq3cka6wdf17-memo-0.5/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rd1jzz81fnlm518155xvaq3cka6wdf17-memo-0.5/bin
patching script interpreter paths in /nix/store/rd1jzz81fnlm518155xvaq3cka6wdf17-memo-0.5
/nix/store/rd1jzz81fnlm518155xvaq3cka6wdf17-memo-0.5/bin/memo: interpreter directive changed from "/bin/bash" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/rd1jzz81fnlm518155xvaq3cka6wdf17-memo-0.5...
/nix/store/rd1jzz81fnlm518155xvaq3cka6wdf17-memo-0.5

@xeji xeji merged commit 696b426 into NixOS:master Jul 31, 2018
@tkerber
Copy link
Member

tkerber commented Aug 1, 2018

This seems to have broken the tarball. I guess it doesn't like aliases?

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

Interesting, thanks for catching this. Looks like the eval-release.nix check doesn't provide aliases. Not sure if this is a bug or feature. Fixed in 26210f5 .

xeji added a commit that referenced this pull request Aug 1, 2018
@xeji
memo: don't use ag alias
26210f5 
using the alias `ag` for `silver-searcher` broke the nixpkgs tarball
with an error in eval-release.nix, see discussion in #44273.
@xeji xeji mentioned this pull request Aug 1, 2018
Closed
@mrVanDalo
Copy link
Contributor Author

@xeji @tkerber will create a fix for it today.

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018 via email

@mrVanDalo
Copy link
Contributor Author

Oh yeah :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrVanDalo @xeji @GrahamcOfBorg @tkerber